After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636778 - Failure to handle files with DVD subpicture streams
Failure to handle files with DVD subpicture streams
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: Media library
Git
Other Linux
: Normal major
: 0.14
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-08 14:31 UTC by Jean-François Fortin Tam
Modified: 2013-09-30 19:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
discoverer: Check streams based on their type and not the caps (1.62 KB, patch)
2010-12-09 19:47 UTC, Edward Hervey
none Details | Review
stream: Fix video/x-dvd-subpicture stream type detection (1.79 KB, patch)
2010-12-09 19:47 UTC, Edward Hervey
none Details | Review

Description Jean-François Fortin Tam 2010-12-08 14:31:21 UTC
https://bugs.launchpad.net/ubuntu/+source/pitivi/+bug/687156
Sample file: http://dl.dropbox.com/u/4812171/Chapter03.mpeg

Traceback (most recent call last):
  • File "/usr/lib/pitivi/python/pitivi/discoverer.py", line 676 in _capsNotifyCb
    stream.thumbnail = self.thumbnails[ghost]
KeyError: <GstPad (dbin:src1) at 33ea7d0>

Comment 1 Edward Hervey 2010-12-09 19:22:05 UTC
We fail handling the (ill-named) video/x-dvd-subpicture format and consider it as a VideoStream (and not TextStream).

I have a local fix for that, but then all hell breaks loose when adding the file to the timeline (it tries to add the subtitle stream to a track).
Comment 2 Edward Hervey 2010-12-09 19:47:22 UTC
Created attachment 176149 [details] [review]
discoverer: Check streams based on their type and not the caps

It kind of beats the point of having stream types being detected
elsewhere otherwise.
Comment 3 Edward Hervey 2010-12-09 19:47:26 UTC
Created attachment 176150 [details] [review]
stream: Fix video/x-dvd-subpicture stream type detection
Comment 4 Edward Hervey 2010-12-09 19:48:29 UTC
Those two patches fix importing files with subtitles...

... but then all hell breaks loose when adding the file to the timeline due to the incredibly overzealously complex stream mapping code which I have no interest in digging into.
Comment 5 Edward Hervey 2010-12-14 20:30:41 UTC
I'll wait for someone to test these patches before anything happens with them.
Comment 6 Jean-François Fortin Tam 2010-12-15 15:24:31 UTC
Ed's two patches seem to fix the problem: the clip now imports and seeks correctly (albeit slowly, but I guess that's normal. Playback works fine).