GNOME Bugzilla – Bug 636778
Failure to handle files with DVD subpicture streams
Last modified: 2013-09-30 19:10:34 UTC
https://bugs.launchpad.net/ubuntu/+source/pitivi/+bug/687156 Sample file: http://dl.dropbox.com/u/4812171/Chapter03.mpeg Traceback (most recent call last):
+ Trace 225036
stream.thumbnail = self.thumbnails[ghost]
We fail handling the (ill-named) video/x-dvd-subpicture format and consider it as a VideoStream (and not TextStream). I have a local fix for that, but then all hell breaks loose when adding the file to the timeline (it tries to add the subtitle stream to a track).
Created attachment 176149 [details] [review] discoverer: Check streams based on their type and not the caps It kind of beats the point of having stream types being detected elsewhere otherwise.
Created attachment 176150 [details] [review] stream: Fix video/x-dvd-subpicture stream type detection
Those two patches fix importing files with subtitles... ... but then all hell breaks loose when adding the file to the timeline due to the incredibly overzealously complex stream mapping code which I have no interest in digging into.
I'll wait for someone to test these patches before anything happens with them.
Ed's two patches seem to fix the problem: the clip now imports and seeks correctly (albeit slowly, but I guess that's normal. Playback works fine).