After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636769 - [appsink] Flushing property is never reset
[appsink] Flushing property is never reset
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.x
Other All
: Normal normal
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-08 12:44 UTC by Tambet Ingo
Modified: 2010-12-10 18:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix. (816 bytes, patch)
2010-12-08 12:46 UTC, Tambet Ingo 		none Details | Review

Description Tambet Ingo 2010-12-08 12:44:32 UTC 
When the element is stopped, flushing is set to TRUE, but it is never reset, so attempting to restart the element, it thinks it's still flushing and doesn't work.
Comment 1 Tambet Ingo 2010-12-08 12:46:01 UTC 
Created attachment 176057 [details] [review]
Proposed fix.
Comment 2 Wim Taymans 2010-12-10 17:44:24 UTC 
That patch is not correct, it never sets the flushing flag to TRUE outside of the lock, which can cause deadlocks.

The proper fix is to set the flushing flag to FALSE in the start method.
Comment 3 Wim Taymans 2010-12-10 18:02:13 UTC 
commit 5f36105915473450eebaceb28e28b0dd6438c02b
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Fri Dec 10 18:57:56 2010 +0100

    appsink: unset flushing flag when starting
    
    When we start again after being stopped, clear the flushing flag or else
    it will always be TRUE.
    
    Fixes #636769