After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636742 - EphyLocationAction: fix potential leak
EphyLocationAction: fix potential leak
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-08 05:17 UTC by Jonathon Jongsma
Modified: 2010-12-08 21:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
EphyLocationAction: fix potential leak (881 bytes, patch)
2010-12-08 05:17 UTC, Jonathon Jongsma 		committed Details | Review

Description Jonathon Jongsma 2010-12-08 05:17:41 UTC 
If the lock_stock_id is set multiple times, the previous value will be
overwritten and leaked.  Potential fix attached.
Comment 1 Jonathon Jongsma 2010-12-08 05:17:43 UTC 
Created attachment 176037 [details] [review]
EphyLocationAction: fix potential leak

Free the lock_stock_id before setting a new one.
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2010-12-08 07:45:45 UTC 
Review of attachment 176037 [details] [review]:

Great, thanks! (do you have commit rights?)
Comment 3 Jonathon Jongsma 2010-12-08 21:41:46 UTC 
thanks.  pushed as eb8fa514e6e3edb93be01d44ecc80608501979df