GNOME Bugzilla – Bug 636523
Unlike other gtk toolbars, Banshee's toolbar isn't painted by the Osliner Radience theme
Last modified: 2013-09-22 17:26:20 UTC
Some themes, such as OslinerRadience[1] paint toolbars with a custom color. This doesn't work in Banshee. I'm guessing that this is the case because Banshee isn't using gtk.Toolbar as a container for the interface widgets (such as playback controls and the seekbar) at the top. For a sampling of the potential awesomeness, see this mockup.[2] [1] http://gnome-look.org/content/show.php/OslinerRadience?content=121418 [2] http://fc07.deviantart.net/fs71/f/2010/337/7/4/banshee_more_natively_themed_by_conorsulli-d344dvn.png
After a little poking around, it looks like Banshee is using a standard gtk toolbar, so I'm not sure why it isn't being colored the same as the toolbar in e.g. Nautilus, Rhythmbox, and MonoDevelop. As a side note, I know virtually nothing about gtk, so I'll keep looking and maybe I'll learn something along the way.
Can this be confirmed with another theme I wonder because it sounds like Osliner might be the buggy one here.
(In reply to comment #2) > Can this be confirmed with another theme I wonder because it sounds like > Osliner might be the buggy one here. I was wondering that too. I don't know of any other themes that have special rules for painting toolbars, though, so I don't know if there is any good baseline to test this against. In my testing, though, Banshee was the only gtk+ application that didn't let this theme set a custom color for the toolbar.
I had a quick look at the OslinerRadience theme, and I couldn't figure out why our toolbar doesn't get the darker color. We are using the regular GTK toolbar. If you want to look into this issue, the "GTK Parasite" tool might be helpful to explore Banshee's widget hierarchy : http://chipx86.github.com/gtkparasite/ (It is packaged in Ubuntu)
We do some custom drawing on our toolbar that probably overrides the theme: http://git.gnome.org/browse/banshee/tree/src/Clients/Nereid/Nereid/PlayerInterface.cs#n432 and http://git.gnome.org/browse/banshee/tree/src/Core/Banshee.ThickClient/Banshee.Gui/BaseClientWindow.cs#n212
(In reply to comment #2) > Can this be confirmed with another theme I wonder because it sounds like > Osliner might be the buggy one here. I can confirm this bug also exists with Equinox theme ppa:tiheum/equinox
Reading the comments of the listed sources: // This forces the toolbar to look like it's just a regular part // of the window since the stock toolbar look makes Banshee look ugly. I tend to disagree, the stock toolbar look doesn't make Banshee ugly, at least not on most themes. I recommend simply removing the ApplyDefaultBackground call from that place, and let the theme apply correctly.
I think part of the problem is that the stock toolbar background clashes with the background for the GrabHandle widget (the widget that lets you resize the search box and player controls). The stock toolbar, depending on the theme, gets drawn with a gradient background. The GrabHandle widget always has a flat background. It's the unfortunate result of gtk automatically drawing a default background for a custom widget.
As the gtk3 branch has now been merged in git master, the custom drawing code for the toolbar is gone. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.