Bug 636509 – Criticals when initializing static field

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 636509 - Criticals when initializing static field


Summary:	Criticals when initializing static field


Status:	RESOLVED FIXED

Product:	vala
Classification:	Core
Component:	general
Version:	0.11.x
Hardware:	Other Linux

Importance:	Urgent normal
Target Milestone:	---
Assigned To:	Vala maintainers
QA Contact:	Vala maintainers

URL:
Whiteboard:	accepts-invalid critical-on-invalid-c...

Depends on:
Blocks:

Reported:	2010-12-05 11:31 UTC by Sebastian Pölsterl
Modified:	2014-08-29 14:56 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Sample code (160 bytes, text/x-vala) 2010-12-05 11:31 UTC, Sebastian Pölsterl		Details
GDB backtrace (31.24 KB, text/plain) 2011-09-22 20:04 UTC, Sebastian Pölsterl		Details
Disallow the use of non-constant initializers of static fields in compact classes (1.03 KB, patch) 2013-03-31 21:45 UTC, Simon Werbeck	none	Details \| Review

Description Sebastian Pölsterl 2010-12-05 11:31:44 UTC

Created attachment 175865 [details]
Sample code

When compiling the attached code I get:

** (valac:14695): CRITICAL **: vala_ccode_function_add_declaration: assertion `self != NULL' failed

** (valac:14695): CRITICAL **: vala_ccode_function_add_expression: assertion `self != NULL' failed

** (valac:14695): CRITICAL **: vala_ccode_function_add_declaration: assertion `self != NULL' failed

** (valac:14695): CRITICAL **: vala_ccode_function_add_expression: assertion `self != NULL' failed

** (valac:14695): CRITICAL **: vala_ccode_function_add_expression: assertion `self != NULL' failed

backtrace:

+ Trace 224988

#0 raise
from /lib/libc.so.6
#1 abort
from /lib/libc.so.6
#2 g_logv
from /lib/libglib-2.0.so.0
#3 g_log
from /lib/libglib-2.0.so.0
#4 vala_ccode_base_module_emit_temp_var
at valaccodebasemodule.c line 13055
#5 vala_ccode_base_module_real_visit_object_creation_expression
at valaccodebasemodule.c line 17525
#6 vala_object_creation_expression_real_emit
at valaobjectcreationexpression.c line 2702
#7 vala_ccode_base_module_real_visit_field
at valaccodebasemodule.c line 3533
#8 vala_class_real_accept_children
at valaclass.c line 1774
#9 vala_gtype_module_real_visit_class
at valagtypemodule.c line 2970
#10 vala_gobject_module_real_visit_class
at valagobjectmodule.c line 523
#11 vala_gd_bus_server_module_real_visit_class
at valagdbusservermodule.c line 6297
#12 vala_source_file_accept_children
at valasourcefile.c line 429
#13 vala_ccode_base_module_real_visit_source_file
at valaccodebasemodule.c line 1903
#14 vala_ccode_base_module_real_emit
at valaccodebasemodule.c line 1353
#15 vala_compiler_run
at valacompiler.c line 993
#16 vala_compiler_main
at valacompiler.c line 1629
#17 main
at valacompiler.c line 1638

Comment 1 Sebastian Pölsterl 2011-09-22 20:04:08 UTC

Created attachment 197289 [details]
GDB backtrace

This issue is still present with 0.14:

** (valac:12824): CRITICAL **: vala_ccode_function_add_declaration: assertion `self != NULL' failed

** (valac:12824): CRITICAL **: vala_ccode_function_add_expression: assertion `self != NULL' failed

** (valac:12824): CRITICAL **: vala_ccode_function_add_assignment: assertion `self != NULL' failed

Comment 2 Jürg Billeter 2011-09-29 17:53:14 UTC

Non-constant expressions are not allowed as initializer for static fields in compact classes. valac should report a compile-time error. In your example it might work to just drop explicit initialization.

Comment 3 Simon Werbeck 2013-03-31 21:45:11 UTC

Created attachment 240261 [details] [review]
Disallow the use of non-constant initializers of static fields in compact classes

Fixes bug 636509

Comment 4 Luca Bruno 2014-08-29 14:56:27 UTC

commit aa52b5be484f0c3d4dfcafe249bdf1c72265c778
Author: Simon Werbeck <simon.werbeck@gmail.com>
Date:   Sun Mar 31 23:39:32 2013 +0200

    Forbid non-constant initializers for static fields in compact classes
    
    Fixes bug 636509

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.