After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636455 - basesrc: Avoid taking object locks for just checking tag presence
basesrc: Avoid taking object locks for just checking tag presence
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 636452 636454 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-12-04 14:35 UTC by Edward Hervey
Modified: 2010-12-17 10:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
basesrc: Use an atomic integer instead of a lock for checking tags presence (2.29 KB, patch)
2010-12-04 14:35 UTC, Edward Hervey
committed Details | Review

Description Edward Hervey 2010-12-04 14:35:34 UTC
basesrc takes the object lock to check the presence of tags. This can be replaced by an atomic integer.
Comment 1 Edward Hervey 2010-12-04 14:35:53 UTC
Created attachment 175836 [details] [review]
basesrc: Use an atomic integer instead of a lock for checking tags presence
Comment 2 Edward Hervey 2010-12-04 14:45:05 UTC
*** Bug 636454 has been marked as a duplicate of this bug. ***
Comment 3 Edward Hervey 2010-12-04 14:45:23 UTC
*** Bug 636452 has been marked as a duplicate of this bug. ***
Comment 4 Sebastian Dröge (slomo) 2010-12-11 16:22:53 UTC
Looks good but are you sure that this makes that much of a difference?
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2010-12-16 21:29:24 UTC
Looks good to me. One less lock on each src's _loop() is quite nice.
Comment 6 Edward Hervey 2010-12-17 10:07:03 UTC
commit 5372e81c9a971195c6b9d2c58a2d472eba3836da
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Sat Dec 4 15:32:06 2010 +0100

    basesrc: Use an atomic integer instead of a lock for checking tags presence
    
    https://bugzilla.gnome.org/show_bug.cgi?id=636455