After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636361 - GTK+ no longer contains GdkDrawable
GTK+ no longer contains GdkDrawable
Status: RESOLVED FIXED
Product: gnome-packagekit
Classification: Core
Component: general
git master
Other Linux
: Normal critical
: ---
Assigned To: gnome-packagekit-maint
gnome-packagekit-maint
Depends on:
Blocks:
 
 
Reported: 2010-12-03 11:13 UTC by Craig Keogh
Modified: 2010-12-04 17:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed fix (1.01 KB, patch)
2010-12-03 15:33 UTC, Wouter Bolsterlee (uws)
committed Details | Review

Description Craig Keogh 2010-12-03 11:13:25 UTC
building using jhbuild on Fedora 14:

gpk-application.o: In function `gpk_application_menu_sources_cb':
/home/Oxyde/gnome/gnome-packagekit/src/gpk-application.c:2757: undefined reference to `gdk_x11_drawable_get_xid'
gpk-application.o: In function `gpk_application_menu_log_cb':
/home/Oxyde/gnome/gnome-packagekit/src/gpk-application.c:2781: undefined reference to `gdk_x11_drawable_get_xid'
collect2: ld returned 1 exit status
make[3]: *** [gpk-application] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Caused by GTK+ API breakage:
http://mail.gnome.org/archives/desktop-devel-list/2010-December/msg00031.html

See:
http://git.gnome.org/browse/gtk+/commit/?id=cf51750bf4b370a180b6273bd99781956165769d
Comment 1 Wouter Bolsterlee (uws) 2010-12-03 15:30:19 UTC
Confirming. This breaks my Gnome build as well.
Comment 2 Wouter Bolsterlee (uws) 2010-12-03 15:33:07 UTC
Created attachment 175787 [details] [review]
Proposed fix
Comment 3 Richard Hughes 2010-12-04 16:57:45 UTC
Review of attachment 175787 [details] [review]:

Thanks!
Comment 4 Wouter Bolsterlee (uws) 2010-12-04 17:17:21 UTC
Bug 636361 — GTK+ no longer contains GdkDrawable

Use the right GTK+ API instead.

[master 8eade6d] Bug 636361 — GTK+ no longer contains GdkDrawable
 1 files changed, 2 insertions(+), 2 deletions(-)

$ git push
Counting objects: 7, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 469 bytes, done.
Total 4 (delta 3), reused 0 (delta 0)
To ssh://git.gnome.org/git/gnome-packagekit
   9ac899f..8eade6d  master -> master