After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636317 - statusMenu: Force the overview mode of the settings
statusMenu: Force the overview mode of the settings
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-12-02 19:20 UTC by Bastien Nocera
Modified: 2010-12-03 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
statusMenu: Force the overview mode of the settings (900 bytes, patch)
2010-12-02 19:20 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2010-12-02 19:20:26 UTC
As requested by Florian
Comment 1 Bastien Nocera 2010-12-02 19:20:29 UTC
Created attachment 175728 [details] [review]
statusMenu: Force the overview mode of the settings

When launching gnome-control-center, request it to show
the overview rather than just presenting the current window.
Comment 2 Owen Taylor 2010-12-03 14:37:07 UTC
Review of attachment 175728 [details] [review]:

Unfortunately, this is going to make the "System Settings" do nothing at all for someone testing the shell with older GNOME.

<owen> can someone with gnome-2 check what 'gnome-control-center -o' does? Does it start with a warning or not start at all?
<fcrozat> owen: unknown option
<fcrozat> doesn't start
<fcrozat> (on 2.30.1)

That isn't a priority problem - the only version of GNOME that GNOME Shell is supposed to work with is GNOME 3, but is there anything obvious to do here? Doesn't seem that gnome-control-center (at least the new version) supports --version and if it did, adding code to parse the output would be unpleasant.

We actually include gnome-control-center in the gnome-shell moduleset, so maybe the right thing to do is to just force running gnome-control-center from the same path. (I don't know if we build a fully working gnome-control-center but it should at least come up.)

Hmm, but that would be easiest to handle when the config.js.in addition in the bluetooth code lands. So, why don't we go ahead and land this patch, and then when someone complains, we can add a workaround to run $prefix/bin/gnome-control-center.
Comment 3 Bastien Nocera 2010-12-03 14:43:37 UTC
(In reply to comment #2)
> Review of attachment 175728 [details] [review]:
> 
> Unfortunately, this is going to make the "System Settings" do nothing at all
> for someone testing the shell with older GNOME.
> 
> <owen> can someone with gnome-2 check what 'gnome-control-center -o' does? Does
> it start with a warning or not start at all?
> <fcrozat> owen: unknown option
> <fcrozat> doesn't start
> <fcrozat> (on 2.30.1)
> 
> That isn't a priority problem - the only version of GNOME that GNOME Shell is
> supposed to work with is GNOME 3, but is there anything obvious to do here?
> Doesn't seem that gnome-control-center (at least the new version) supports
> --version

It most certainly does, I added it at the same time as "-o".

> and if it did, adding code to parse the output would be unpleasant.
> 
> We actually include gnome-control-center in the gnome-shell moduleset, so maybe
> the right thing to do is to just force running gnome-control-center from the
> same path. (I don't know if we build a fully working gnome-control-center but
> it should at least come up.)
> 
> Hmm, but that would be easiest to handle when the config.js.in addition in the
> bluetooth code lands. So, why don't we go ahead and land this patch, and then
> when someone complains, we can add a workaround to run
> $prefix/bin/gnome-control-center.

I would think that it's a case for distributions fixing their dependencies, rather than for us to try and work around problems like that.
Comment 4 Bastien Nocera 2010-12-03 14:44:23 UTC
Attachment 175728 [details] pushed as b40cc2c - statusMenu: Force the overview mode of the settings
Comment 5 Florian Müllner 2010-12-03 14:58:33 UTC
(In reply to comment #2)
> Review of attachment 175728 [details] [review]:
> 
> Unfortunately, this is going to make the "System Settings" do nothing at all
> for someone testing the shell with older GNOME.

At least for now, gnome-control-center 3 is part of the moduleset, so it should take preference over the system version anyway.
Comment 6 Owen Taylor 2010-12-03 15:58:46 UTC
(In reply to comment #5)
> (In reply to comment #2)
> > Review of attachment 175728 [details] [review] [details]:
> > 
> > Unfortunately, this is going to make the "System Settings" do nothing at all
> > for someone testing the shell with older GNOME.
> 
> At least for now, gnome-control-center 3 is part of the moduleset, so it should
> take preference over the system version anyway.

We don't set $PATH in the gnome-shell wrapper script. (and not sure we should)
Comment 7 Owen Taylor 2010-12-03 16:00:13 UTC
(In reply to comment #3)
> > Hmm, but that would be easiest to handle when the config.js.in addition in the
> > bluetooth code lands. So, why don't we go ahead and land this patch, and then
> > when someone complains, we can add a workaround to run
> > $prefix/bin/gnome-control-center.
> 
> I would think that it's a case for distributions fixing their dependencies,
> rather than for us to try and work around problems like that.

Not concerned about distros, more concerned about people using the gnome-shell jhbuild on older distros (which, as Florian says does build gnome-control-center. I'm not completely sure it builds a *working* control center, and it won't be on $PATH)