After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636301 - Port testgradient example to GTK3
Port testgradient example to GTK3
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2010-12-02 14:56 UTC by Benjamin Otte (Company)
Modified: 2010-12-02 23:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ui: Port testgradient example to GTK3 (6.45 KB, patch)
2010-12-02 14:56 UTC, Benjamin Otte (Company) 		committed Details | Review

Description Benjamin Otte (Company) 2010-12-02 14:56:47 UTC 
Ports the testgradient example to GTK3. It'll probably not do anything but throw warnings to stderr currently. I only noticed this example because it fails to compile with GTK3 rendering-cleanup. I could also just delete it?
Comment 1 Benjamin Otte (Company) 2010-12-02 14:56:49 UTC 
Created attachment 175711 [details] [review]
ui: Port testgradient example to GTK3
Comment 2 Florian Müllner 2010-12-02 22:19:54 UTC 
Review of attachment 175711 [details] [review]:

Looks good.

::: src/ui/testgradient.c
@@ +237,1 @@
+  return FALSE;

Why do you need to propagate the signal?
Comment 3 Benjamin Otte (Company) 2010-12-02 23:01:57 UTC 
I suppose I just did that out of habit. It's generally a bad idea to return TRUE because you don't get dnd highlights and disallow connect_after() signals. So I fix it everywhere to not let get people get in the habit of doing the wrong thing.

In this particular case, it doesn't matter of course.