After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636267 - gst-package-release-datetime.m4 doesn't work on FreeBSD
gst-package-release-datetime.m4 doesn't work on FreeBSD
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: common
0.10.31
Other FreeBSD
: Normal normal
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-02 01:24 UTC by Koop Mast (kwm)
Modified: 2010-12-04 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Teach gst-package-release-datetime.m4 to work on FreeBSD. (577 bytes, patch)
2010-12-02 01:27 UTC, Koop Mast (kwm)
none Details | Review

Description Koop Mast (kwm) 2010-12-02 01:24:34 UTC
On FreeBSD Gstreamer 0.10.31 configure fails with the following error:
This seems to stem from the fact that our /bin/sh isn't bash.

--------------------------------------------------
configure: Using GST_PKG_CONFIG_PATH = $(top_builddir)/pkgconfig
Usage: ./configure RELEASE-VERSION-NUMBER DOAP-FILE
configure: error: SET_PACKAGE_RELEASE_DATETIME: could not extract
            release date for release version  0.10.31  from  "./gstreamer.doap"
--------------------------------------------------
Comment 1 Koop Mast (kwm) 2010-12-02 01:27:09 UTC
Created attachment 175689 [details] [review]
Teach gst-package-release-datetime.m4 to work on FreeBSD.

"./" is fine as long extract-release-date-from-doap-file is executable.
If you want to play it save in case the above file isn't executable. "sh" or even "/bin/sh" would be a beter choice.
Comment 2 Tim-Philipp Müller 2010-12-04 14:34:04 UTC
Committed this, hope it's ok:


commit 9aa18ac420a19332ec215be14a6b966cc45948cf
Author: Koop Mast <kwm@FreeBSD.org>
Date:   Sat Dec 4 14:21:09 2010 +0000

    gst-package-release-datetime.m4: make work with FreeBSD's default shell
    
    http://bugzilla-attachments.gnome.org/attachment.cgi?id=175689

diff --git a/m4/gst-package-release-datetime.m4 b/m4/gst-package-release-datetime.m4
index e0b9334..126919b 100644
--- a/m4/gst-package-release-datetime.m4
+++ b/m4/gst-package-release-datetime.m4
@@ -37,7 +37,7 @@ AC_DEFUN([AG_GST_SET_PACKAGE_RELEASE_DATETIME],
       GST_PACKAGE_RELEASE_DATETIME=$1
     else
       dnl we assume the .doap file contains the date as YYYY-MM-DD
-      YYYY_MM_DD=`. "${srcdir}/common/extract-release-date-from-doap-file" $3 $2`;
+      YYYY_MM_DD=`sh "${srcdir}/common/extract-release-date-from-doap-file" $3 $2`;
       if test "x$YYYY_MM_DD" != "x"; then
         GST_PACKAGE_RELEASE_DATETIME=$YYYY_MM_DD
       else


Thanks for the patch!