After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636233 - [PATCH] background: convert to GDBus
[PATCH] background: convert to GDBus
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: background
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2010-12-01 17:46 UTC by Dan Williams
Modified: 2010-12-01 17:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
convert background code to GDBus (6.76 KB, patch)
2010-12-01 17:46 UTC, Dan Williams 		accepted-commit_now Details | Review

Description Dan Williams 2010-12-01 17:46:07 UTC 
For some reason the signal filter with plain DBus wasn't working
correctly, leading to no background when nautilus was for whatever
reason not autolaunched, and show-desktop-icons was TRUE.  In any
case it should be GDBus not libdbus, so port it.  That also
happens to fix the signal listening issue.
Comment 1 Dan Williams 2010-12-01 17:46:41 UTC 
Created attachment 175638 [details] [review]
convert background code to GDBus
Comment 2 Cosimo Cecchi 2010-12-01 17:52:13 UTC 
Review of attachment 175638 [details] [review]:

Looks good to me, thanks.
Comment 3 Dan Williams 2010-12-01 17:57:56 UTC 
34d6831d7bf5fdf869f1b4802d8920c4a90825db

thanks for the review!