GNOME Bugzilla – Bug 636214
Merging express account setup auto configuration to evolution
Last modified: 2012-06-28 15:52:14 UTC
In express mode it automatically recognize the user's email setup settings if he uses gmail, yahoo, msn and aol servers and set them in appropriate way. It would be great to merge this feature in evolution.
Created attachment 198528 [details] [review] Evolution Patch Making a guess of server based on api : http://api.gnome.org/evolution/autoconfig as done in express. This is part 1 of patch.
Created attachment 198529 [details] [review] Evolution Patch Part-2 of above patch.
It would be nice if you can submit a patch that includes the movement of files and another with the rest of the changes which applies on master.
Created attachment 200956 [details] [review] Evolution Patch Part1 Fine, I have divided the patch in three parts. First is removal of files from capplet/settings/. Second is to add them in mail/. Third contains code changes. All three patches apply to master successfully, hope this would help. Thanks!
Created attachment 200957 [details] [review] Evolution Patch Part2
Created attachment 200958 [details] [review] Evolution Patch Part3
Review of attachment 200956 [details] [review]: please commit.
Review of attachment 200957 [details] [review]: please commit.
Review of attachment 200958 [details] [review]: Please make this change and commit the patch. ::: capplet/settings/mail-account-view.c @@ -1081,3 @@ "org.gnome.evolution.mail.config.accountWizard", view->wpages); gtk_widget_hide (e_config_create_widget (E_CONFIG (view->edit->config))); - view->edit->emae_check_servers = emae_check_servers; This virtual function can be removed from EMAccountEditor as it is not used anymore.
I was wondering if my setup had an issue. But it looks like there is an issue with auto-configuration working, please fix it and commit the patch.
*** Bug 663658 has been marked as a duplicate of this bug. ***
Patches are committed in master (3.3.x) and will be part of 3.3.2
Created attachment 201225 [details] [review] Evolution Patch This patch is to create review page as we do in express mode, which will display all basic settings to user. I have combined old management page in the review page. It can set google and yahoo addressbook and calendar for user. It also set some default settings. I tried to jump to review page directly from identity page if we are able to fetch details from server. But there is some problems while hiding and showing pages. Currently account setup is bit messed up and not working correctly. I have left this just for now and will do after the account setup starts working.
Created attachment 201226 [details] A sample of Review Page This is how review page looks like for a google account.
Review of attachment 201225 [details] [review]: "Always(SSL)" and "When possible(TLS)" are missing whitespaces in-between. Please use proper spelling. "Review Account" - that's inconsistent: The rest are all gerunds, this one is not. Maybe "Account Summary"? "Time to check things over before we try and connect to the server and fetch your mail." - don't like the colloquial style, plus the "we", whoever that is. maybe "This is a summary of the settings that will be used to access your mail."
...plus if that page is for "Review" only, it should NOT ask me to enter stuff anymore, like entering the account name.
Even though there's some more touch ups to be done, I'm going to expedite the review and commit this immediately to master so I can rebase my account-mgmt branch against it. I have my own major surgery to do on the account editor. It seems to work as well as described. Nice job on the first cut! The account editor code is already kind of a mess and so the changes look about as clean as they can be and build without warnings. Just work with Andre on the wording. http://git.gnome.org/browse/evolution/commit/?id=ab43706fc6c374cc04d71610be9da5d7e13922ab
Created attachment 201355 [details] [review] Evolution Patch Thanks Matthew! Andre : I have changed strings according to your suggestions. We have "Account Summary" instead of "Review Account" and added a space too:). Please have a look to the patch so I can go ahead and commit it. Thanks!
Replace mails by mail and it's good to commit. Thanks for working on this!
Review of attachment 201355 [details] [review]: Patch has been committed with "mail". Thanks! http://git.gnome.org/browse/evolution/commit/?id=604948f1b5522c020128106eb4466af134648d83
Created attachment 203934 [details] [review] Evolution Patch It deprecates CamelURL and uses CamelSettings plus some minor changes. Bug 664095 is also solved by this patch as we are not dependent on CamelURL all configuration is available through CamelSettings. Thanks!
Nice! Changes look good but the patch doesn't apply cleanly anymore. Feel free to update the patch and commit it yourself.
Review of attachment 203934 [details] [review]: Thanks Matthew, Patch has been committed to master branch. http://git.gnome.org/browse/evolution/commit/?id=fbbb2988f68bba66ccb07823e4917d7085eb8772
Can this bug be closed or anything else is left here ?
The UI needs a bit of polish and we're still not jumping to the summary page when we auto-populate account details, but I think we can close this bug and open new ones for further tweaks as needed.
*** Bug 590523 has been marked as a duplicate of this bug. ***