After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636198 - decodebin2: "removed-decoded-pad" signal never fired
decodebin2: "removed-decoded-pad" signal never fired
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-01 09:34 UTC by Philip Jägenstedt
Modified: 2010-12-13 08:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
decodebin2: Emit "remove-decoded-pad" signal when pads are removed from decodebin2 (1.11 KB, patch)
2010-12-11 16:15 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Philip Jägenstedt 2010-12-01 09:34:43 UTC 
The documentation mentions "removed-decoded-pad" but this seems to never be actually fired in the code. uridecodebin instead listens to "pad-removed", which I presume is then the correct way.

The "removed-decoded-pad" signal should be removed/deprecated or it should be implemented as per the documentation.
Comment 1 Sebastian Dröge (slomo) 2010-12-11 16:15:51 UTC 
Created attachment 176242 [details] [review]
decodebin2: Emit "remove-decoded-pad" signal when pads are removed from decodebin2

Fixes bug #636198.
Comment 2 Sebastian Dröge (slomo) 2010-12-11 16:17:12 UTC 
Right, the signals are really redundant and should be removed later in 0.11 (new-decoded-pad == pad-added and removed-decoded-pad == pad-removed).

I've committed the patch above to make it at least possible to use the signal ;)
Comment 3 Philip Jägenstedt 2010-12-13 07:46:04 UTC 
Thanks, that makes things clearer!

Is new-decoded-pad really equivalent to pad-added? Doesn't new-decoded-pad also ensure that the pad is a "raw" type?
Comment 4 Sebastian Dröge (slomo) 2010-12-13 08:41:25 UTC 
All pads added to decodebin2 are "raw" pads