GNOME Bugzilla – Bug 636143
avidemux: report creation date/time via GST_TAG_DATE_TIME
Last modified: 2019-05-07 18:40:05 UTC
Currently the avidemux element can report an AVI video's creation date (but not time) using the GST_TAG_DATE tag. GStreamer now has a GST_TAG_DATE_TIME tag, so we should enhance avidemux to report the full date/time using this tag.
Created attachment 175561 [details] [review] avidemux: Also emit DateTime tag
Created attachment 175562 [details] [review] avidemux: Also extract IDIT tags present too early
Created attachment 175569 [details] [review] avidemux: Also emit DateTime tag
latest version parses as much as possible from the IDIT tags.
FWIW, most of the remaining info is in proprietary blobs. A good chunk of them are detailed here : http://search.cpan.org/~exiftool/Image-ExifTool-8.15/lib/Image/ExifTool/TagNames.pod The question is ... where to put all that parsing :(
Edward, the patches look good, can you push them? Support in the muxer would be nice too. Form the RIFF-Tags http://search.cpan.org/~exiftool/Image-ExifTool-8.15/lib/Image/ExifTool/TagNames.pod#RIFF_Tdat_Tags we can easily add exif/xmp support, by calling the exif/xmp helpers now :)
(In reply to comment #6) > Edward, the patches look good, can you push them? Support in the muxer would be > nice too. They were pushed some time ago > > Form the RIFF-Tags > http://search.cpan.org/~exiftool/Image-ExifTool-8.15/lib/Image/ExifTool/TagNames.pod#RIFF_Tdat_Tags > we can easily add exif/xmp support, by calling the exif/xmp helpers now :) I meant the non exif/xmp ones. commit 86933b40e928d1697a1eb72ded294e8714f00b9b Author: Edward Hervey <bilboed@bilboed.com> Date: Tue Nov 30 19:22:11 2010 +0100 avidemux: Also extract IDIT tags present too early https://bugzilla.gnome.org/show_bug.cgi?id=636143 commit 0cff917a519da449a9dc6f26def7a1b4531c2056 Author: Edward Hervey <bilboed@bilboed.com> Date: Tue Nov 30 19:21:23 2010 +0100 avidemux: Also emit DateTime tag https://bugzilla.gnome.org/show_bug.cgi?id=636143
Great. Can this now be marked fixed?
It can't be closed, a lot of files still fail as mentionned in comment #5
OK - thanks for the explanation. By the way, this page contains a set of sample AVI files from many different cameras, submitted by Shotwell users: http://trac.yorba.org/wiki/AVISamples It appears that GStreamer 0.10.32 can read date/time information from some, but not all, of these files. It would be great if GStreamer could handle them all since then Shotwell could switch to using GStreamer for this purpose. :)
... those were the files I was talking about (yes, we do track your work) :) Just needs a good soul to write that boring parsing code though.
OK - glad you knew about those files. :) You might be able to lift some AVI date-time parsing code from Shotwell itself. We've implemented it there since GStreamer doesn't have this capability yet. See http://trac.yorba.org/browser/shotwell/trunk/src/VideoMetadata.vala
Still applies. Here are the updated links for links above: http://redmine.yorba.org/projects/shotwell/wiki/AVISamples http://git.yorba.org/cgit.cgi/shotwell/tree/src/VideoMetadata.vala
It would be useful to have sections in the wiki for * files that work * files with missing metadata * new files Also having the files in a place that one can rsync would be sweet.
For reference, this command works to fetch/update all files: wget -m -nd --accept=AVI,avi,MPG,mpg,MP4,mp4,MOV,mov http://redmine.yorba.org/projects/shotwell/wiki/AVISamples
I went through all the files and for those where we don't show a DATETIME in discoverer checked with tabriffdump/mp4info/ffprobe to check that they don't have datetimes either. The only stuff that seem to be left are nikon files: http://www.eden-foundation.org/products/code/film_date_stamp/ from LIST/ncdt we can get Maker/Model and Datetime. Will make a patch later today.
commit f653aa8c8562dda69e2be13d2b305a0ff4361690 Author: Stefan Sauer <ensonic@users.sf.net> Date: Sat Jan 4 21:31:07 2014 +0100 riff: add support for nikon tags Nikon cameras store metadata in a custom format. Add parsing of the chunk and extract some initial data. API: gst_riff_parse_ncdt() Fixes #636143 commit f48bb20b4f2852166d897ac03fa89b4a3a396b59 Author: Stefan Sauer <ensonic@users.sf.net> Date: Sat Jan 4 21:34:38 2014 +0100 avi: use new riff api to extract nikon metadata Fixes #636143 This gets us tags for 4 more files: DSC_0001.AVI DSC_6519.AVI DSCN2516.AVI Nikon_Coolpix_S3000.AVI There is still one variant left - the fuji specific strd tag.
Cool that you're fixing these, but did we really need to add new public API for a function that will likely only ever be used by avidemux?
I was wondering too. There is a bit of reuse for the function I extracted. But I can also just copy this to avidemux if thats preferable. I did not found anything wheter this can occur in asf files.
Tim, I moved the code to avidemux.
commit 5384da2a1f821ee1272eeaf2dbda0983eb8ec708 Author: Stefan Sauer <ensonic@users.sf.net> Date: Sun Jan 5 22:41:24 2014 +0100 avidemux: parse fuji strd We can get maker, model and capture date from this chunk. Fixes #636143 Closing this bug. Please let us know if there are new files/chunks/...
Adam, not sure if this got merged in shotwell, but now you won't need it anymore: https://github.com/Sanva/shotwell-gsoc/blob/master/src/VideoMetadata.vala