After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636132 - afc: Add support for House Arrest protocol
afc: Add support for House Arrest protocol
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: afc backend and volume monitor
unspecified
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2010-11-30 14:38 UTC by Bastien Nocera
Modified: 2011-05-16 14:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
afc: Add support for House Arrest protocol (50.13 KB, patch)
2010-11-30 14:38 UTC, Bastien Nocera
none Details | Review
afc: Add support for House Arrest protocol (52.86 KB, patch)
2010-12-01 01:39 UTC, Bastien Nocera
none Details | Review
afc: Add support for House Arrest protocol (53.27 KB, patch)
2010-12-01 02:26 UTC, Bastien Nocera
none Details | Review
afc: Add support for House Arrest protocol (53.86 KB, patch)
2010-12-03 01:37 UTC, Bastien Nocera
none Details | Review
afc: Add support for House Arrest protocol (54.69 KB, patch)
2010-12-06 01:19 UTC, Bastien Nocera
none Details | Review
afc: Add support for House Arrest protocol (55.65 KB, patch)
2010-12-06 01:52 UTC, Bastien Nocera
none Details | Review
afc: Add support for House Arrest protocol (56.42 KB, patch)
2010-12-06 02:34 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2010-11-30 14:38:53 UTC
Quite chunky patch attached
Comment 1 Bastien Nocera 2010-11-30 14:38:57 UTC
Created attachment 175533 [details] [review]
afc: Add support for House Arrest protocol

To access the Documents/ folder within applications.
Comment 2 Bastien Nocera 2010-12-01 01:39:05 UTC
Created attachment 175597 [details] [review]
afc: Add support for House Arrest protocol

To access the Documents/ folder within applications.
Comment 3 Bastien Nocera 2010-12-01 02:26:06 UTC
Created attachment 175599 [details] [review]
afc: Add support for House Arrest protocol

To access the Documents/ folder within applications.
Comment 4 Bastien Nocera 2010-12-01 02:28:02 UTC
- Tested on iPhone 4.0.1 and iPad 4.2.1.
- apps have their icons loaded and cached
- loads of memory leak fixes, and warnings on clean umount
Comment 5 John Stowers 2010-12-01 03:16:16 UTC
AFAIK this support was only added in libimobiledevice master. Perhaps configure should require libimobiledevice-1.0 > 1.1.0
Comment 6 Bastien Nocera 2010-12-03 01:37:03 UTC
Created attachment 175750 [details] [review]
afc: Add support for House Arrest protocol

To access the Documents/ folder within applications.
Comment 7 Bastien Nocera 2010-12-03 01:37:54 UTC
Comment on attachment 175599 [details] [review]
afc: Add support for House Arrest protocol

Latest patch fixes an abort() with some apps that use a different scheme for the UIFileSharingEnabled key.
Comment 8 Bastien Nocera 2010-12-06 01:19:04 UTC
Created attachment 175895 [details] [review]
afc: Add support for House Arrest protocol

To access the Documents/ folder within applications.
Comment 9 Bastien Nocera 2010-12-06 01:20:41 UTC
Comment on attachment 175895 [details] [review]
afc: Add support for House Arrest protocol

- Use "Documents on %s" instead of "Applications on %s"
- Load all the apps, not just the ones that support file sharing, just hide them by default
- protect apps loading with a mutex
Comment 10 Bastien Nocera 2010-12-06 01:52:39 UTC
Created attachment 175897 [details] [review]
afc: Add support for House Arrest protocol

To access the Documents/ folder within applications.
Comment 11 Bastien Nocera 2010-12-06 01:53:29 UTC
Comment on attachment 175895 [details] [review]
afc: Add support for House Arrest protocol

- And a version that starts AFC services on demand, so we don't end up with missing apps.
Comment 12 Bastien Nocera 2010-12-06 02:34:10 UTC
Created attachment 175899 [details] [review]
afc: Add support for House Arrest protocol

To access the Documents/ folder within applications.
Comment 13 Bastien Nocera 2010-12-06 02:35:15 UTC
Comment on attachment 175897 [details] [review]
afc: Add support for House Arrest protocol

And now we hide everything but the Documents sub-folder by default to avoid people damaging the app on purpose.
Comment 14 Bastien Nocera 2010-12-17 11:38:14 UTC
Attachment 175899 [details] pushed as 5f6132b - afc: Add support for House Arrest protocol
Comment 15 Raphael Hertzog 2011-04-22 06:05:01 UTC
Hello,

libimobiledevice 1.1.x is a development release and its API is not yet officially stable, it's a pity that the (stable) released version of gvfs now depends on an unstable library.

Can this support be made conditional on the detected version of libimobiledevice instead?

Alternatively someone can convince upstream developers of libimobiledevice to make a stable release.
Comment 16 Bastien Nocera 2011-05-16 14:51:34 UTC
(In reply to comment #15)
> Hello,
> 
> libimobiledevice 1.1.x is a development release and its API is not yet
> officially stable, it's a pity that the (stable) released version of gvfs now
> depends on an unstable library.

I don't really see the problem here. libimobiledevice 1.1.x works fine.

> Can this support be made conditional on the detected version of
> libimobiledevice instead?
> 
> Alternatively someone can convince upstream developers of libimobiledevice to
> make a stable release.

The stable release is planned, and all the blockers are related to parts that don't affect the afc backend's ability to function.