After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636070 - gloverlay: add jpeg support
gloverlay: add jpeg support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-gl
git master
Other Linux
: Normal normal
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-29 17:02 UTC by anthony
Modified: 2012-02-18 20:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to implement jpeg file in gloverlay (881.47 KB, patch)
2010-11-29 17:04 UTC, anthony
needs-work Details | Review

Description anthony 2010-11-29 17:02:40 UTC
With this patch, you can now put jpeg file in the parameter location of gloverlay.
We can put jpeg file or png file now.
Example pipeline with this patch :

gst-launch-0.10 videotestsrc ! glupload ! gloverlay location=file.jpeg video-top=true proportion-video=50 proportion-png=50 xpos-video=90 ! gldownload ! xvimagesink
Comment 1 anthony 2010-11-29 17:04:06 UTC
Created attachment 175482 [details] [review]
patch to implement jpeg file in gloverlay
Comment 2 Sebastian Dröge (slomo) 2010-12-18 13:50:09 UTC
Could you please attach a new patch without configure or any other unrelated things and also without idention changes in the header (or elsewhere)? That would make reviewing much easier :)

And please attach patches in git format-patch format, that way a commit message, your name and mailm address are included already
Comment 3 anthony 2010-12-29 13:32:44 UTC
Hello,

I don't unedrstand because you want that attach only gstgloverlay.c and gstgloverlay.h?
But if i attach only tgis file, the plugin don't work, so who will manage the configuration aobut libjpeg?
About the indentation i have change anything so what do you wuant exactly?
My patch that attach is format git format-patch with a message, i have just forget to add, in this message.

Best regards,
Anthony
Comment 4 Julien Isorce 2011-11-17 14:24:34 UTC
commit 8ad415e32b32c035ca7996fa5fed476979587a00
Author: Anthony Violo <anthony.violo@ubicast.eu>
Date:   Thu Nov 17 15:22:06 2011 +0100

    gloverlay: add jpeg support
    
    Fix bug #636070