GNOME Bugzilla – Bug 635958
Don't export private symbols in the library
Last modified: 2011-01-12 15:24:27 UTC
Currently, private symbols (prefixed with an underscore) are exported in the shared library: 0000000000002ed0 T _notify_cache_add_notification 0000000000002eb0 T _notify_cache_remove_notification 0000000000002e60 T _notify_check_spec_version 0000000000002ef0 T _notify_get_proxy 0000000000004040 T _notify_notification_get_timeout 0000000000003610 T _notify_notification_has_nondefault_actions The attached patch tells libtool to use -export-symbols-regex to not export _foo symbols. Let me know if it's OK to push.
Created attachment 175391 [details] [review] Don't export private symbols in the shared library
+ -export-symbols-regex "^[^_].*" Probably better to specify which symbols should be exported, instead of which should not be exportedl. Sth like using "^notify_*".
Created attachment 175407 [details] [review] Only export notify_* symbols Sounds like a good idea. This new patch does exactly that.
ping? Can I push this?
Comment on attachment 175407 [details] [review] Only export notify_* symbols I've pushed this as 9d5e8582b38fd95e8aa32b427504ca9fefcb6a3c
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
(In reply to comment #5) > I've pushed this as 9d5e8582b38fd95e8aa32b427504ca9fefcb6a3c Emilio: Where and by whom was this reviewed?
He was already gently chastised on irc. I'm assured it was tested and he'll fix any problems that arise. :)
Yes, I shouldn't have done that. I apoligize for it, and it won't happen again. [ FTR: it was tested and verified to be working, and I've pushed similar changes to gnome-keyring and gnome-desktop at least. Not an excuse though, that doesn't justify my mistake ]