Created attachment 175341 [details] [review]
Add counts back to top level sources

I'm not sure it is worth the (small) additional visual clutter. I'm not really interested in knowing whether I have 2378 or 2379 tracks in my collection.

Unlike the podcast source or the play queue, the total number of tracks in the music library only changes after an explicit action from the user : import tracks, rescan library, sync from dap, or copy files to the Music folder...

And the information is always only one click away : Select the Music source and it's displayed in the status bar, in a more interesting way (total length and disk size).

I've posted about this on banshee-list, and at the suggestion of Michael Martin-Smucker, I'm adding my arguments (plus some additional ones) here.  I agree with Alex, and here are some reasons that I find source totals worth the (alleged) additional visual clutter.

* First, I don't think the totals involve any appreciable visual clutter.  My music source has 14 playlists, each with a listed total, and the music source itself is the only thing without a total, so very little additional clutter would be involved -- in fact, I would argue that the "holes" left in the total column of the sources panel from the absence of source totals is itself a kind of visual clutter.

* I've created a smart playlist of my whole library (the first of the 14 playlists mentioned above), which is there just so that I'd have the total available at a glance, but it wastes valuable vertical space.

* Having all the totals available at a glance lets me see approximately how much of my library is on any particular device, or compare the sizes of the libraries on different devices (my desktop machine has 7 USB ports).

* It also makes it easy to see if a drag-and-drop to a device moved all of the songs.

* Even if the visual clutter argument wins the day, it should still be feasible to put checkboxes in the Preferences -- one in General for all sources, and then one for each source under Miscellaneous in Source Specific -- to allow those of us happy with the value of the extra "visual clutter" to enable it.

I third Alex and Todd, the counts save clicks and add little clutter because the playlists already have them. I'm for committing the patch.

I'm fine with it too

Comment on attachment 175341 [details] [review]
Add counts back to top level sources

Committed, to have it for 1.9.3, and to show that I don't mind changing my mind ;)

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.