Created attachment 175337 [details]
Removes obsolete DragDropTargets and warnings about hiding

Created attachment 175338 [details] [review]
Removes obsolete DragDropTargets and warnings about method hiding

Deskzilla did not allow me to specify it as a patch proper. I will have to attach them through the web interface from now on.

Review of attachment 175338 [details] [review]:

::: src/Clients/MainApp/FSpot/TagSelectionWidget.cs
@@ +536,3 @@
 		}
 
+        /*

Good looking patch, is there any reason why you've commented this block of code rather than just delete it?

Nope, good catch, thanks.

Created attachment 175387 [details] [review]
Removes obsolete DragDropTargets and warnings about method hiding

I also moved the extension methods to the FSpot.Utils namespace/folder since it seemed more appropriate there (and there were plenty of others there). This is also the first time I've created a patch based on rebasing/squashing multiple commits into one so hopefully it is sufficient.

Investigating merge for master :-)

Merged to master. Won't merge this to stable as it's not a critical fix. As this is something that will mostly benefit us during development (less horrible warnings!), it's not that much of a problem: development should happen on master anyway (with occasional backports to stable).

Agreed. I was going to leave a comment saying as much but figured it was obviously not relevant for stable. This is part of "my eliminate warnings when building in Monodevelop" campaign.