GNOME Bugzilla – Bug 635800
xvimagesink flashes black when going from READY_TO_NULL
Last modified: 2011-04-05 08:38:28 UTC
gst_xvimagesink_xwindow_clear() is painting the window black when going from READY_TO_NULL. It's something we should make optional I think (and remove at some point). Its also inconsistent as apps would need to make their video window black initially if they want it to be black.
What would you propose as solution? A property to select the color that should be used when going back to NULL *and* in the beginning? Or a property to disable this behaviour completely?
Probably disable drawing via option now and drop it in 0.11. We don't paint the recange black initially, so we should not do it later too.
I don't see the point in a property, just remove the behaviour. We want to get back to NULL as quickly as possible, right?
(In reply to comment #3) > I don't see the point in a property, just remove the behaviour. We want to get > back to NULL as quickly as possible, right? That'd be fine for my, but it means that for apps that don't paint one sees the colorkey now, But if noone object, lets just remove it.
So apparently nobody objected (at least here in the bug report). Hence I am setting to NEW. Feel free to change if you don't think it's appropriate.
commit 38aba7853eb3027489fc2b67bafc9f4db6b89b39 Author: Stefan Kost <ensonic@users.sf.net> Date: Tue Apr 5 11:32:52 2011 +0300 xvimagesink: don't paint the window black when going to NULL Leave dealing with the appearance of the window when we are not playing to the applications. We anyway want to go to NULL as quickly as possible. Fixes #635800