After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635738 - Sanitize Previous/Next buttons when not usable
Sanitize Previous/Next buttons when not usable
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.30.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2010-11-25 01:00 UTC by Nick Jenkins
Modified: 2010-11-30 08:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
evo patch (3.38 KB, patch)
2010-11-26 10:23 UTC, Milan Crha
committed Details | Review

Description Nick Jenkins 2010-11-25 01:00:24 UTC
Previous and Next buttons when at the end or beginning of the messages in a folder: in Evo 2.28, when you got to the newest message, then the Next button would be greyed out; now in 2.30.3 & current git master, it's still available, but clicking it does nothing. Same for the previous button on the oldest message in a folder.

I kind of liked the old behavior, because then could tell when I was at the beginning or the end. Now it just feels like my computer is ignoring me.

Proposed solution, either:
a) disabling the button, as per previous versions.
b) or make clicking it close the message window, to signify that the user has got to the end of the folder.
Comment 1 Milan Crha 2010-11-26 10:23:20 UTC
Created attachment 175302 [details] [review]
evo patch

for evolution;

Sanitizes all Go To menu items based on the actual position of the cursor in the message list.
Comment 2 Milan Crha 2010-11-26 10:26:14 UTC
Created commit b0ec195 in evo master (2.91.3+)
Created commit 97b56f8 in evo gnome-2-32 (2.32.2+)
Comment 3 Nick Jenkins 2010-11-26 11:10:43 UTC
Yay, thank you, that's an amazingly quick resolution :-)
Comment 4 Milan Crha 2010-11-30 08:38:33 UTC
I realized that EMailBrowser wasn't updating actions on select, thus even it knew what to do it didn't do it. Fixed in follow-up commits:

Created commit 9f9eb9b in evo master (2.91.4+)
Created commit 950309c in evo gnome-2-32 (2.32.2+)