After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635669 - [vorbistag] Support METADATA_BLOCK_PICTURE for Vorbis cover art
[vorbistag] Support METADATA_BLOCK_PICTURE for Vorbis cover art
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.x
Other Linux
: Normal normal
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-24 07:57 UTC by Jason
Modified: 2011-04-01 10:55 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jason 2010-11-24 07:57:21 UTC
http://wiki.xiph.org/VorbisComment#METADATA_BLOCK_PICTURE

Seems totem only the cover art image in "COVERART" filed in ogg tag, but that's not official standard.

xmms2 also have this problem: http://bugs.xmms2.xmms.se/view.php?id=2398

ogg examples can be found here:
http://trac.videolan.org/vlc/ticket/1616
http://bugzilla.mplayerhq.hu/show_bug.cgi?id=1056
Comment 1 Jason 2010-11-24 16:20:32 UTC
you sure this is related to gstreamer? because exaile can handle OGG embedded cover art in this way.
Comment 2 Philip Withnall 2010-11-24 20:09:40 UTC
I'm fairly sure it's just GStreamer not handling the new tag.
Comment 3 Arun Raghavan 2011-02-01 08:51:15 UTC
Is this problem still occurring I don't see it here with the file linked to on the VLC bug. I'm using:

totem 2.32.0
gstreamer 0.10.31
gst-plugins-base 0.10.31
Comment 4 Sebastian Dröge (slomo) 2011-04-01 09:42:07 UTC
The new version of that file only uses the old COVERART tag it seems.
Comment 5 Sebastian Dröge (slomo) 2011-04-01 09:46:11 UTC
We still don't implement support for METADATA_BLOCK_PICTURE in vorbiscomments but I don't have a sample file
Comment 6 Sebastian Dröge (slomo) 2011-04-01 09:54:59 UTC
Ok, found a sample and will work on it now.
Comment 7 Sebastian Dröge (slomo) 2011-04-01 10:55:50 UTC
commit 35064fdc8283f3ba51a4c0082c4d97f9c20eb668
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri Apr 1 12:52:05 2011 +0200

    vorbistag: Write GST_TAG_IMAGE and GST_TAG_PREVIEW_IMAGE as METADATA_BLOCK_P
    
    This is the official, standardized way of embedding images into
    vorbiscomments now.

commit 57ff12bb0d3dd6936bd160b35e4fa45796959440
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri Apr 1 12:28:28 2011 +0200

    vorbistag: Add support for METADATA_BLOCK_PICTURE tags
    
    This is the official, standardized way of embedding pictures
    inside vorbiscomments now. Parsing code taken from flacparse
    and slightly changed.
    
    Fixes bug #635669.