GNOME Bugzilla – Bug 635615
Embed page setup dialog in the print dialog
Last modified: 2012-02-12 12:53:42 UTC
There is a possibility of embedding the paper size combo and orientation
combo in the print dialog since Gtk+ 2.17.4. It is activated by calling the
It would be nice to have this feature also in the GIMP, as photos/images do not have an absolute size. You select the print size of a photo only when you actually print it and photos are often printed on sizes which are not the standard size of the printer (4x6 inches/10x15 cm). So the page size and orientation should be easily accessible during the printing action, which means that they are best placed in the printing dialog.
To implement this one only needs a small patch doing the following things:
- Remove the "Page Setup" menu entries (and toolbar buttons)
- Remove call-back functions to open the "Page Setup" dialog
- Add call of gtk_print_operation_set_embed_page_setup() function to
initialization of print dialog
- Add calls to load page setup setting on print dialog initialization and
save them on OK/Print/Apply in print dialog (to remember next print dialog
call or even next session).
See the patches attached to
See also the Ubuntu Blueprint for improving usability of photo printing:
and the same bug report for f-spot:
Also reported to Ubuntu as
Yeah, this print dialog split has always felt like utter crack, would
you provide patches for what you suggest?
I am working on this one, will provide a patch soon.
Created attachment 175449 [details] [review]
Now, this is a rough patch, sorry for that. I am not very good in this field, and this is the first time I am working on the Printing part of GTK+ .
It would be very helpful for a more experienced developer to review this patch.
Fixed in master:
Author: Michael Natterer <email@example.com>
Date: Sun Feb 12 13:51:18 2012 +0100
Bug 635615 - Embed page setup dialog in the print dialog
Get rid of the antique separate page setup menu item and dialog.
Started with a patch from Bilal Akhtar but massively changed it, and
fixed some undiscovered bugs on the way.
plug-ins/print/print-page-layout.c | 16 ++++
plug-ins/print/print-page-setup.c | 17 ----
plug-ins/print/print-page-setup.h | 9 +-
plug-ins/print/print.c | 155 +++---------------------------------
4 files changed, 32 insertions(+), 165 deletions(-)