After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635615 - Embed page setup dialog in the print dialog
Embed page setup dialog in the print dialog
Product: GIMP
Classification: Other
Component: Plugins
Other All
: Normal normal
: 2.8
Assigned To: GIMP Bugs
Depends on:
Reported: 2010-11-23 13:59 UTC by Till Kamppeter
Modified: 2012-02-12 12:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Patch #1 (12.42 KB, patch)
2010-11-29 08:12 UTC, Bilal Akhtar
none Details | Review

Description Till Kamppeter 2010-11-23 13:59:08 UTC
There is a possibility of embedding the paper size combo and orientation
combo in the print dialog since Gtk+ 2.17.4. It is activated by calling the
gtk_print_operation_set_embed_page_setup() function.

It would be nice to have this feature also in the GIMP, as photos/images do not have an absolute size. You select the print size of a photo only when you actually print it and photos are often printed on sizes which are not the standard size of the printer (4x6 inches/10x15 cm). So the page size and orientation should be easily accessible during the printing action, which means that they are best placed in the printing dialog.

To implement this one only needs a small patch doing the following things:

 - Remove the "Page Setup" menu entries (and toolbar buttons)
 - Remove call-back functions to open the "Page Setup" dialog
 - Add call of gtk_print_operation_set_embed_page_setup() function to 
   initialization of print dialog
 - Add calls to load page setup setting on print dialog initialization and
   save them on OK/Print/Apply in print dialog (to remember next print dialog 
   call or even next session).

See the patches attached to

See also the Ubuntu Blueprint for improving usability of photo printing:

and the same bug report for f-spot:
Comment 1 Till Kamppeter 2010-11-23 16:22:27 UTC
Also reported to Ubuntu as
Comment 2 Michael Natterer 2010-11-25 00:27:08 UTC
Yeah, this print dialog split has always felt like utter crack, would
you provide patches for what you suggest?
Comment 3 Bilal Akhtar 2010-11-28 08:01:18 UTC
I am working on this one, will provide a patch soon.
Comment 4 Bilal Akhtar 2010-11-29 08:12:09 UTC
Created attachment 175449 [details] [review]
Patch #1

Now, this is a rough patch, sorry for that. I am not very good in this field, and this is the first time I am working on the Printing part of GTK+ .

It would be very helpful for a more experienced developer to review this patch.

Comment 5 Michael Natterer 2012-02-12 12:53:42 UTC
Fixed in master:

commit bdc3f7e7e0495b599a712c917d6ab17f05f92164
Author: Michael Natterer <>
Date:   Sun Feb 12 13:51:18 2012 +0100

    Bug 635615 - Embed page setup dialog in the print dialog
    Get rid of the antique separate page setup menu item and dialog.
    Started with a patch from Bilal Akhtar but massively changed it, and
    fixed some undiscovered bugs on the way.

 plug-ins/print/print-page-layout.c |   16 ++++
 plug-ins/print/print-page-setup.c  |   17 ----
 plug-ins/print/print-page-setup.h  |    9 +-
 plug-ins/print/print.c             |  155 +++---------------------------------
 4 files changed, 32 insertions(+), 165 deletions(-)