After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635601 - background panel loads synchronously
background panel loads synchronously
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Background
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-23 11:54 UTC by William Jon McCann
Modified: 2010-12-13 16:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description William Jon McCann 2010-11-23 11:54:18 UTC 
The background panel should load the wallpapers asynchronously and should not delay showing the main UI.

Currently there are at least two serious problems:
 * data models are loaded in the constructor
 * images are loaded in a synchronous loop

For example:
http://git.gnome.org/browse/gnome-control-center/tree/panels/background/bg-pictures-source.c#n150
Comment 1 Bastien Nocera 2010-12-13 16:21:02 UTC 
commit 44fbef70a292b7ae049554ffd6949d53e3b66d64
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Dec 13 16:19:58 2010 +0000

    background: Load ~/Pictures asynchronously
    
    Using the new gdk-pixbuf helper functions in 2.23.0.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=635601

commit 9580be8d17d6902632ce1785c25dfb69f60d48ea
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Dec 13 15:30:22 2010 +0000

    background: Avoid re-querying the GFileInfo
    
    If we already have it from enumerating the Pictures directory. Saves
    us from doing sync queries in certain cases.