After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635571 - Compile fails in gtkhtml/gtkhtml-embedded.c on gtk3 branch
Compile fails in gtkhtml/gtkhtml-embedded.c on gtk3 branch
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: API
3.91.x
Other Linux
: Normal normal
: ---
Assigned To: Vibha Yadav
gtkhtml-maintainers
evolution[gtk3]
: 633458 636178 636900 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-11-23 00:52 UTC by Frank Solensky
Modified: 2010-12-26 07:29 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
Patch for build failure as size_request is deprecated (4.65 KB, patch)
2010-11-25 12:08 UTC, Vibha Yadav 		none Details | Review
Patch for build failure as size_request is deprecated (7.72 KB, patch)
2010-11-26 10:10 UTC, Vibha Yadav 		committed Details | Review

Description Frank Solensky 2010-11-23 00:52:50 UTC 
As a result of running into bug #634532, I'm now trying to build the gtk3 branch of gtkhtml.  The compile fails as follows:

Making all in gtkhtml
make[2]: Entering directory `/home/frank/checkout/gnome/gtkhtml/gtkhtml'
  CC     gtkhtml-embedded.lo
  CC     gtkhtml-properties.lo
  CC     gtkhtml-search.lo
gtkhtml-embedded.c: In function 'gtk_html_embedded_class_init':
gtkhtml-embedded.c:204:14: error: 'GtkWidgetClass' has no member named 'size_request'
make[2]: *** [gtkhtml-embedded.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/home/frank/checkout/gnome/gtkhtml/gtkhtml'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/frank/checkout/gnome/gtkhtml'
make: *** [all] Error 2

Does the gtk3 branch require that some other modules also be built with something other than their master branches?

TIA.
Comment 1 Vibha Yadav 2010-11-25 12:08:27 UTC 
Created attachment 175237 [details] [review]
Patch for build failure as size_request is deprecated

Using get_preferred_width and get_preferred_height instead of size_request.
Comment 2 Craig Keogh 2010-11-26 09:37:17 UTC 
There are two more locations where size_request is used (beyond Vibha Yadav's patch):
components/editor/gtkhtml-color-combo.c:714:14
components/editor/gtkhtml-color-swatch.c:177:14
Comment 3 Vibha Yadav 2010-11-26 10:10:05 UTC 
Created attachment 175301 [details] [review]
Patch for build failure as size_request is deprecated

Including patch for above mentioned locations too.
Comment 4 Chenthill P 2010-11-29 10:19:27 UTC 
Review of attachment 175301 [details] [review]:

looks good. please commit.
Comment 5 Wouter Bolsterlee (uws) 2010-11-30 23:17:30 UTC 
*** Bug 636178 has been marked as a duplicate of this bug. ***
Comment 6 Vibha Yadav 2010-12-06 12:28:08 UTC 
Committed patch to gtk3 branch.
Comment 7 Vibha Yadav 2010-12-10 08:23:43 UTC 
*** Bug 636900 has been marked as a duplicate of this bug. ***
Comment 8 Craig Keogh 2010-12-26 07:29:36 UTC 
*** Bug 633458 has been marked as a duplicate of this bug. ***