After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635529 - interlace: Add pattern offset and fix timestamps
interlace: Add pattern offset and fix timestamps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-22 14:54 UTC by Robert Swain
Modified: 2010-11-30 23:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add pattern offset capability (4.34 KB, patch)
2010-11-22 14:55 UTC, Robert Swain
committed Details | Review
Rename pattern property to field-pattern (1.16 KB, patch)
2010-11-22 14:56 UTC, Robert Swain
committed Details | Review
Fix outgoing buffer timestamps and durations (1.31 KB, patch)
2010-11-22 14:56 UTC, Robert Swain
committed Details | Review

Description Robert Swain 2010-11-22 14:54:51 UTC
The following patches add support for a pattern offset so that telecine patterns can be started at any point in the pattern. Also, for the sake of clarity, the pattern property is renamed to field-pattern and there is a timestamp/duration fix for the outgoing buffers.
Comment 1 Robert Swain 2010-11-22 14:55:54 UTC
Created attachment 175039 [details] [review]
Add pattern offset capability
Comment 2 Robert Swain 2010-11-22 14:56:23 UTC
Created attachment 175040 [details] [review]
Rename pattern property to field-pattern
Comment 3 Robert Swain 2010-11-22 14:56:50 UTC
Created attachment 175041 [details] [review]
Fix outgoing buffer timestamps and durations
Comment 4 David Schleef 2010-11-22 21:23:13 UTC
Looks good.

It would be a good idea also to add an "automatic" boolean that allows the user to choose between automatic mode (which isn't very good right now) and manual mode, which would be useful for converting 24p and 30p HDV streams.
Comment 5 Robert Swain 2010-11-24 12:23:30 UTC
What would the automatic mode do? The default pattern could be set to 1:1 for the old 60p -> 60i behaviour. I should probably do that.
Comment 6 David Schleef 2010-11-24 22:11:22 UTC
Oops, I looked at the patches and thought "invtelecine", not "interlace".  No worries, same comments apply.
Comment 7 Robert Swain 2010-11-24 22:48:19 UTC
Perhaps we could close this ticket and you could open a new one with details of what you mean for whichever element? :) I'm a bit confused now.
Comment 8 David Schleef 2010-11-24 22:51:53 UTC
Already closed, yo.

(IMO, my random chatting about ideas for features is not reason to keep a bug open.)