After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635528 - configure.ac: move call to AM_GNU_GLIB_GETTEXT above cflags modification
configure.ac: move call to AM_GNU_GLIB_GETTEXT above cflags modification
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2010-11-22 14:53 UTC by Owen Taylor
Modified: 2010-11-22 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
configure.ac: move call to AM_GNU_GLIB_GETTEXT above cflags modification (1.11 KB, patch)
2010-11-22 14:55 UTC, Owen Taylor 		reviewed Details | Review
configure.ac: move CFLAGS modifications after all tests (4.29 KB, patch)
2010-11-22 15:28 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2010-11-22 14:53:30 UTC 
-Werror in CFLAGS was causing the check for GNU gettext to fail,
resulting in .po files in $libdir.
Comment 1 Owen Taylor 2010-11-22 14:55:22 UTC 
Created attachment 175038 [details] [review]
configure.ac: move call to AM_GNU_GLIB_GETTEXT above cflags modification
Comment 2 Owen Taylor 2010-11-22 14:56:31 UTC 
See:

https://bugzilla.redhat.com/show_bug.cgi?id=650023

for original report. It may be that abandoning the use of AM_GNU_GLIB_GETTEXT() in favor of the upstream version would also provide a fix.
Comment 3 Dan Winship 2010-11-22 15:10:37 UTC 
Comment on attachment 175038 [details] [review]
configure.ac: move call to AM_GNU_GLIB_GETTEXT above cflags modification

>+## gettext - this has to be before the addition of -Werror to cflags

It would probably be better to move the CFLAGS+=-Werror to the end instead; There are probably lots of AC_TRY_COMPILEs out there that can't pass "-Wmissing-prototypes -Werror"
Comment 4 Owen Taylor 2010-11-22 15:28:46 UTC 
Created attachment 175044 [details] [review]
configure.ac: move CFLAGS modifications after all tests

-Werror in CFLAGS was causing the check for GNU gettext in
AM_GNU_GLIB_GETTEXT to fail, resulting in .mo files in $libdir.
Comment 5 Owen Taylor 2010-11-22 15:50:51 UTC 
Attachment 175044 [details] pushed as 54e82da - configure.ac: move CFLAGS modifications after all tests