GNOME Bugzilla – Bug 635439
[PATCH] Payment dialog fixes
Last modified: 2018-06-29 22:47:55 UTC
Created attachment 174961 [details] [review] Patch to autoset owner in the payment dialog (against trunk r19847) > Here's a patch to fix a pet peeve I've had for quite some time with the > invoice payment dialog: Make it possible to enter just the invoice > (number), instead of always needing to select the owner manually. This > is especially useful when processing bank statements, when the invoice > number is listed on the statement. > > I've added a second patch, for a bug I noticed while digging through the > code. Note that the inconsistent use of spaces in between a function > name and the opening brace for the arguments is to remain consistent > with the surrounding code (but dialog-payment.c uses different > styles...). > > Patches are against current SVN trunk (r19847).
Created attachment 174962 [details] [review] Patch to autoset invoice in an open payment dialog when choosing "Pay Inovice" (against trunk r19847)
r19853, r19854, thanks a lot!
This patch breaks GnuCash for me. Selecting pay invoice while an invoice is open fills in the customer field with the job instead of the customer. Selecting OK crashes. This only occurs where there is a job associated with an invoice, no job no problem. GnuCash.gnc_invoice_set_invoice: assertion `invoice != NULL' failed
(In reply to comment #3) > This patch breaks GnuCash for me. Oops. Can you narrow down which one of the two patches will cause the crash for you? Feel free to directly revert either one or both so that the patch will be improved before being applied again. Of course a newly introduced crash is no good, so you can revert it right away.
Woops, didn't realize the job / owner issue. The != NULL assertion has a different cause (It's probably also triggered when changing the owner after selecting an invoice). Two patches to fix this coming up.
Created attachment 175032 [details] [review] 0001-Fix-Pay-invoice-for-invoices-that-have-a-job.patch - Fix for "Patch to autoset owner in the payment dialog" Here's two additional patches to fix these issues. Sorry for the breakage...
Created attachment 175033 [details] [review] 0002-Let-gnc_invoice_set_invoice-accept-a-NULL-invoice.patch - Second fix for "Patch to autoset owner in the payment dialog"
Matthijs: Can you submit the complete patch again and not just the diffs on you last patch? I'd reverted your original to avoid having a broken SVN.
Created attachment 175034 [details] [review] Updated version of "Patch to autoset owner in the payment dialog" that fixes the issues Ah, I didn't see the revert yet when I was preparing the patches. Here's a new patch with the original patch and the two fixes squashed together.
Comment on attachment 175034 [details] [review] Updated version of "Patch to autoset owner in the payment dialog" that fixes the issues Committed r19861 Thanks!
FYI, it looks like this patch causes another problem. See Bug #637041
*** Bug 637041 has been marked as a duplicate of this bug. ***
Created attachment 176561 [details] [review] Revert temporary revert of r19951.
Matthijs: Any updates here so that it doesn't crash anymore?
Comment on attachment 176561 [details] [review] Revert temporary revert of r19951. Matthijs: Can you re-submit a changed patch from comment#13 which has the crasher of bug#637041 resolved? Thanks!
Matthijs, were you able to re-submit the fix as per comment#15 ?
Closing this bug report as no further information has been provided.
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=635439. Please update any external references or bookmarks.