GNOME Bugzilla – Bug 635428
Use a standard way to highlight elements
Last modified: 2020-03-17 08:58:45 UTC
I have noticed that Banshee does not seem to follow the way other apps in my distribution highlight items, or show the active pane; normally apps highlight items using an orange colour, which changes to grey when that pane (or the whole app) is not focused. Instead, Banshee seems to use orange for all panes, the focused one as well as the unfocused, and shows which pane is focused by drawing a second border inside it. This deviation from the norm makes more difficult to guess what will happen if you press a given key (e.g. the tab key or a direction key), so using the standard way would be beneficial.
Thanks for the report. Can you attach a screenshot showing what you mean?
Created attachment 175050 [details] Screenshot Sure. The attached screenshot shows how your typical gnome app (in this case, rhythmbox) shows which pane is active: the screenshot shows selected items in the sources, artists and tracks panes, but only the one in the tracks pane is orange, because it's the active pane. Selected items in the sources and artists panes are grey.
Created attachment 175051 [details] Screenshot As for this screenshot, it shows how banshee shows the active pane: you can see selected items in the sources, artists and albums panes, but all three of them use orange (instead of the standard grey) for selected items. The artists pane has a thicker border than the other two, because it's the active pane.
Great, thanks for the screenshots David, that did clear it up for me.
Just a tip for anyone who feels like working on this. The class to edit is probably Hyena.Data.Gui.ListView_Rendering.cs
*** Bug 636443 has been marked as a duplicate of this bug. ***
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.