After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635252 - [patch] Make gnome-2-32 branch build against glib >= 2.27.1
[patch] Make gnome-2-32 branch build against glib >= 2.27.1
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: build
unspecified
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2010-11-19 09:05 UTC by Vincent Untz
Modified: 2011-03-21 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do not build app lookup extension if we have glib >= 2.27.1 (1.88 KB, patch)
2010-11-19 09:06 UTC, Vincent Untz
committed Details | Review

Description Vincent Untz 2010-11-19 09:05:56 UTC
There will be people using glib 2.28 with GNOME 2.32. So for gvfs, we want to check the glib version before deciding whether the app lookup extension should be built or not. Here's a simple patch for it.
Comment 1 Vincent Untz 2010-11-19 09:06:00 UTC
Created attachment 174829 [details] [review]
Do not build app lookup extension if we have glib >= 2.27.1
Comment 2 André Klapper 2010-12-29 23:42:53 UTC
PING.
Comment 3 Tomas Bzatek 2011-03-11 17:30:36 UTC
Vincent, looking at the changes in gvfs 1.7 series I see no reason why people would not be able to run new gvfs with new glib in an old distro. The changes made don't really affect anything else.

I'm not against pushing your patch to the stable branch, just being curious :-)
Comment 4 Vincent Untz 2011-03-11 18:55:52 UTC
We needed the patch because in openSUSE 11.4, we use glib 2.28 with GNOME 2.32, ie gvfs 1.6.
Comment 5 Tomas Bzatek 2011-03-21 15:55:41 UTC
Committed to gnome-2-32, 1.6.7 maintenance release will follow shortly...

commit 7552d43b182c00fe0479f56920f09170aafd5662
Author: Vincent Untz <vuntz@gnome.org>
Date:   Mon Mar 21 16:43:11 2011 +0100

    Do not build app lookup extension if we have glib >= 2.27.1
    
    https://bugzilla.gnome.org/show_bug.cgi?id=635252