After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635244 - pygi-convert.sh should cover buttons and message type constants
pygi-convert.sh should cover buttons and message type constants
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: introspection
Git master
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-19 08:02 UTC by Martin Pitt
Modified: 2010-11-19 17:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
convert message and buttons types (977 bytes, patch)
2010-11-19 08:04 UTC, Martin Pitt
committed Details | Review
specify files on command line (1.50 KB, patch)
2010-11-19 08:10 UTC, Martin Pitt
none Details | Review
Remove sugar specifics, specify files on command line (2.23 KB, patch)
2010-11-19 17:17 UTC, Martin Pitt
committed Details | Review
convert pynotify to Notify GIR (867 bytes, patch)
2010-11-19 17:20 UTC, Martin Pitt
committed Details | Review

Description Martin Pitt 2010-11-19 08:02:44 UTC
Current version doesn't convert GtkMessageDialog flags: Gtk.MESSAGE_* -> Gtk.MessageType.*, and Gtk.BUTTONS_* -> Gtk.ButtonsType.*.
Comment 1 Martin Pitt 2010-11-19 08:04:21 UTC
Created attachment 174823 [details] [review]
convert message and buttons types

OK for me to push?
Comment 2 Martin Pitt 2010-11-19 08:10:37 UTC
Created attachment 174825 [details] [review]
specify files on command line

Would you consider applying this patch as well? It makes it much easier to use pygi-convert.sh for other projects without having to edit the script.
Comment 3 Johan (not receiving bugmail) Dahlin 2010-11-19 13:04:40 UTC
(In reply to comment #2)
> Created an attachment (id=174825) [details] [review]
> specify files on command line
> 
> Would you consider applying this patch as well? It makes it much easier to use
> pygi-convert.sh for other projects without having to edit the script.

I'd just remove the sugar specific files and let Tomeu do that himself outside of the script.
Comment 4 johnp 2010-11-19 16:40:07 UTC
Comment on attachment 174823 [details] [review]
convert message and buttons types

This looks good.  Thanks
Comment 5 Martin Pitt 2010-11-19 16:42:58 UTC
Comment on attachment 174823 [details] [review]
convert message and buttons types

Thanks, pushed the buttons/message type patch.

I didn't push the second patch yet, as there were some concerns from Johan.
Comment 6 johnp 2010-11-19 16:48:58 UTC
I think he was saying just remove the sugar specific stuff and make it generic.
Comment 7 Martin Pitt 2010-11-19 17:17:06 UTC
Created attachment 174861 [details] [review]
Remove sugar specifics, specify files on command line

OK, this is a more generic one.
Comment 8 Martin Pitt 2010-11-19 17:20:53 UTC
Created attachment 174863 [details] [review]
convert pynotify to Notify GIR

Shamelessly abusing this bug for another patch review. libnotify got a proper GIR yesterday, this will help with the conversion.
Comment 9 Martin Pitt 2010-11-19 17:41:03 UTC
Both pushed, thanks!