After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635199 - build: fix gnome-power-manager dependencies
build: fix gnome-power-manager dependencies
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: building
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-11-18 17:45 UTC by Frederic Crozat
Modified: 2010-11-21 00:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: fix gnome-power-manager dependencies (1.27 KB, patch)
2010-11-18 17:45 UTC, Frederic Crozat 		none Details | Review
Fix dependencies for gnome-power-manager (2.56 KB, patch)
2010-11-19 17:44 UTC, Giovanni Campagna 		committed Details | Review

Description Frederic Crozat 2010-11-18 17:45:50 UTC 
This patch fixes build dependencies for gnome-power-manager
Comment 1 Frederic Crozat 2010-11-18 17:45:52 UTC 
Created attachment 174785 [details] [review]
build: fix gnome-power-manager dependencies

gnome-power-manager needs libgnome-keyring, not gnome-keyring to be
built.
Comment 2 Dan Winship 2010-11-18 18:09:18 UTC 
hm... so how did it work for the rest of us?

how is it failing?
Comment 3 Frederic Crozat 2010-11-18 18:21:45 UTC 
maybe because you had libgnome-keyring-devel installed as a package, which got picked by pkgconfig.
Comment 4 Dan Winship 2010-11-18 18:48:25 UTC 
ah, i was just assuming it would need a recent libgnomekeyring, but apparently an ancient one is fine. in that case i'm not sure we want to be building it at all, rather than just adding it as a package dependency
Comment 5 Giovanni Campagna 2010-11-19 17:44:13 UTC 
Created attachment 174866 [details] [review]
Fix dependencies for gnome-power-manager

Merging the g-p-m branch with the one adding gnome-settings-daemon
for A11y, a lot of modules were duplicated. Also, gnome-keyring is
not needed, the distro provided one is enough.
Comment 6 Dan Winship 2010-11-19 18:34:17 UTC 
Comment on attachment 174866 [details] [review]
Fix dependencies for gnome-power-manager

>+    libgnome-keyring-devel

add it to the "generic" list as well

otherwise good
Comment 7 Jeremy Nickurak 2010-11-21 00:32:02 UTC 
This seems to have broken building since gnome-power-manager requires gnome-keyring-1, but the commonly available gnome-keyring version (2.32.*) provides gnome-keyring (lacking the -1) via pkgconfig.
Comment 8 Jeremy Nickurak 2010-11-21 00:37:16 UTC 
OTOH, this may be an ubuntu bug. I assume that "/usr/lib/pkgconfig/gnome-keyring-1.pc" should have a "Name: gnome-keyring-1"? In maverick it has "Name: gnome-keyring"...