After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635144 - [external-editor] Using external editor duplicates signature
[external-editor] Using external editor duplicates signature
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Plugins
2.28.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-plugin-maintainers
Evolution QA team
evolution[signatures]
Depends on:
Blocks:
 
 
Reported: 2010-11-18 03:48 UTC by David Clayton
Modified: 2011-02-01 17:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
evo patch (8.53 KB, patch)
2011-02-01 17:08 UTC, Milan Crha
committed Details | Review

Description David Clayton 2010-11-18 03:48:47 UTC
When composing a new e-mail message (with an auto-signature set for the account) and then using the "Compose in External Editor" function, when closing the external editor (Gedit) and returning to the Evolution message window the Signature is added again.
Comment 1 Omer Akram 2010-11-18 21:15:36 UTC
also reported at: https://bugs.launchpad.net/ubuntu/+source/evolution/+bug/676390
Comment 2 Milan Crha 2011-02-01 17:08:46 UTC
Created attachment 179812 [details] [review]
evo patch

for evolution;

This is not a full fix for the issue, but it may fix most common scenario, which means opening a new message or reply to a message (the body contains a signature), edit it through an external editor, and when closing the external editor then the text is replaced in the message body and the signature is not duplicated.

Unfortunately the signature will be duplicated when one begins to play with sending account settings or signature setting itself. It's because the relevant information about previous signature position got lost when passing message body to the external editor, so the composer doesn't know where the signature was placed (note of cases like top/bottom posting/signature placing; replying to a message and so on) and cannot replace it there.
Comment 3 Milan Crha 2011-02-01 17:10:10 UTC
Created commit a10247b in evo master (2.91.90+)