After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635120 - Region spans multiple-of-3
Region spans multiple-of-3
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Gtk2
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2010-11-17 22:24 UTC by Kevin Ryde
Modified: 2010-11-27 14:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch and test cases (2.77 KB, patch)
2010-11-17 22:24 UTC, Kevin Ryde 		none Details | Review
patch and test cases (2.65 KB, patch)
2010-11-24 22:26 UTC, Kevin Ryde 		committed Details | Review

Description Kevin Ryde 2010-11-17 22:24:59 UTC 
Created attachment 174725 [details] [review]
patch and test cases

The croak message in gdk_region_spans_intersect_foreach() refers to GdkPoints, but I think the spans are triples not pairs.  The need for triples might be enforced too, ie demand a multiple of 3.
Comment 1 Torsten Schoenfeld 2010-11-24 20:46:32 UTC 
I hit "assertion `spans != NULL'" for the zero test.  So we should probably disallow that case, but at least we shouldn't be using it in the test suite.
Comment 2 Kevin Ryde 2010-11-24 22:22:19 UTC 
Oh, I don't know why I missed that spans==NULL.  I might have had a skip zero length patch in progress at the same time.  If constructing an array it's extremely annoying to have to check if it's non-empty before calling that sort of func, or the draw_points() of the other bug.  Much friendlier to quietly do nothing on an empty input.  But I'll take that out of the tests to start with.
Comment 3 Kevin Ryde 2010-11-24 22:26:49 UTC 
Created attachment 175208 [details] [review]
patch and test cases

Without the empty array test case.
Comment 4 Torsten Schoenfeld 2010-11-27 14:16:05 UTC 
Looks great, committed.  Thanks.