After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635117 - Replace size_request by get_preferred_width/height
Replace size_request by get_preferred_width/height
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sound
2.91.x
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 633505 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-11-17 21:24 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-11-19 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace size_request by get_preferred_width/height (2.45 KB, patch)
2010-11-17 21:25 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
gvc-sound-theme-chooser: Replace size_request signal (1.65 KB, patch)
2010-11-19 16:48 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-11-17 21:24:39 UTC 
As It'll removed soon from GTK+3
Comment 1 Javier Jardón (IRC: jjardon) 2010-11-17 21:25:25 UTC 
Created attachment 174720 [details] [review]
Replace size_request by get_preferred_width/height
Comment 2 Bastien Nocera 2010-11-18 14:44:05 UTC 
Comment on attachment 174720 [details] [review]
Replace size_request by get_preferred_width/height

There's one more "size-request" signals used to constrain the height of the
treeview. Any chance for you to check it?
Comment 3 Bastien Nocera 2010-11-18 15:22:42 UTC 
*** Bug 633505 has been marked as a duplicate of this bug. ***
Comment 4 Javier Jardón (IRC: jjardon) 2010-11-19 16:48:24 UTC 
Created attachment 174858 [details] [review]
gvc-sound-theme-chooser: Replace size_request signal

Untested patch (of course compiles) as gnome-control-center crashes here on startup (before apply the patch).
Comment 5 Bastien Nocera 2010-11-19 17:38:51 UTC 
gvc-sound-theme-chooser.c: In function ‘setup_list_size_constraint’:
gvc-sound-theme-chooser.c:1016:53: warning: passing argument 1 of ‘gtk_scrolled_window_set_min_content_height’ from incompatible pointer type
/home/hadess/Projects/gnome-install/include/gtk-3.0/gtk/gtkscrolledwindow.h:122:16: note: expected ‘struct GtkScrolledWindow *’ but argument is of type ‘struct GtkWidget *’
Comment 6 Bastien Nocera 2010-11-19 17:39:29 UTC 
Attachment 174858 [details] pushed as 5c53a05 - gvc-sound-theme-chooser: Replace size_request signal