After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635112 - Buildable GET_INTERNAL_CHILD return undef
Buildable GET_INTERNAL_CHILD return undef
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Gtk2
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2010-11-17 20:51 UTC by Kevin Ryde
Modified: 2010-11-24 21:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch and test case (3.05 KB, patch)
2010-11-17 20:51 UTC, Kevin Ryde
committed Details | Review

Description Kevin Ryde 2010-11-17 20:51:27 UTC
Created attachment 174717 [details] [review]
patch and test case

The Gtk2::Buildable pod shows GET_INTERNAL_CHILD return as "object or undef" but returning undef throws a perl error in SvGObject, where I expected it to return NULL to the builder.

That NULL still results in a GError from the builder, but I think it should be left to the builder to do whatever it should do for an unknown internal child.
Comment 1 Torsten Schoenfeld 2010-11-24 21:14:12 UTC
The test belongs in GtkBuildableIface.t, and our copyright footers are not
Lisp, so there's no need to align parens. :-)  Other than that, the patch looks
great.

Committed with these changes.
Comment 2 Kevin Ryde 2010-11-24 21:37:23 UTC
Actually that indent would be cperl-indent-command being over-enthusiastic, but it was probably my own created indent-this-block command extending too far which gave it a look past the __END__ :-)