GNOME Bugzilla – Bug 635112
Buildable GET_INTERNAL_CHILD return undef
Last modified: 2010-11-24 21:37:23 UTC
Created attachment 174717 [details] [review] patch and test case The Gtk2::Buildable pod shows GET_INTERNAL_CHILD return as "object or undef" but returning undef throws a perl error in SvGObject, where I expected it to return NULL to the builder. That NULL still results in a GError from the builder, but I think it should be left to the builder to do whatever it should do for an unknown internal child.
The test belongs in GtkBuildableIface.t, and our copyright footers are not Lisp, so there's no need to align parens. :-) Other than that, the patch looks great. Committed with these changes.
Actually that indent would be cperl-indent-command being over-enthusiastic, but it was probably my own created indent-this-block command extending too far which gave it a look past the __END__ :-)