Created attachment 174692 [details] [review]
cleanup leftover "views" directories

I've been preparing packages for evolution 2.32 on Ubuntu and I've noticed an issue in migrating files from the .evolution directory into new xdg dirs: "views" appear to be properly migrated but the base views directories for each backend does not get removed, even though it's empty.

Here's the output of 'find .evolution -print' after opening evolution for the first time and after migration:

.evolution
.evolution/calendar
.evolution/calendar/views
.evolution/tasks
.evolution/tasks/views
.evolution/memos
.evolution/memos/views
.evolution/addressbook
.evolution/addressbook/views

I think this remains because the "views" directories for each backend are migrated in shell_xdg_migrate_config_dir_common() using shell_xdg_migrate_rename_files() instead of shell_xdg_migrate_rename() -- the base "views" isn't renamed, just each of the paths contained therein.

The attached patch changes shell_xdg_migrate_config_dir_cleanup() to allow passing it a directory name, and reuses that function to cleanup "views" after the "config" directories are removed.