After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635087 - Leftover files after migration of config/data/cache to XDG directories
Leftover files after migration of config/data/cache to XDG directories
Product: evolution
Classification: Applications
Component: Shell
2.32.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
: 631762 648065 (view as bug list)
Depends on:
Reported: 2010-11-17 16:47 UTC by Mathieu Trudel-Lapierre
Modified: 2011-04-18 02:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

cleanup leftover "views" directories (2.09 KB, patch)
2010-11-17 16:47 UTC, Mathieu Trudel-Lapierre
committed Details | Review

Description Mathieu Trudel-Lapierre 2010-11-17 16:47:22 UTC
Created attachment 174692 [details] [review]
cleanup leftover "views" directories

I've been preparing packages for evolution 2.32 on Ubuntu and I've noticed an issue in migrating files from the .evolution directory into new xdg dirs: "views" appear to be properly migrated but the base views directories for each backend does not get removed, even though it's empty.

Here's the output of 'find .evolution -print' after opening evolution for the first time and after migration:


I think this remains because the "views" directories for each backend are migrated in shell_xdg_migrate_config_dir_common() using shell_xdg_migrate_rename_files() instead of shell_xdg_migrate_rename() -- the base "views" isn't renamed, just each of the paths contained therein.

The attached patch changes shell_xdg_migrate_config_dir_cleanup() to allow passing it a directory name, and reuses that function to cleanup "views" after the "config" directories are removed.
Comment 1 Milan Crha 2010-11-23 09:41:14 UTC
Thanks for a bug report and patch, the change seems fine to me, thus I'm committing it.
Comment 2 Milan Crha 2010-11-23 09:50:04 UTC
Created commit 863b9bf in evo master (2.91.3+)
Created commit d3d6d96 in evo gnome-2-32 (2.32.2+)
Comment 3 Matthew Barnes 2010-12-12 14:28:39 UTC
*** Bug 631762 has been marked as a duplicate of this bug. ***
Comment 4 Matthew Barnes 2011-04-18 02:54:28 UTC
*** Bug 648065 has been marked as a duplicate of this bug. ***