GNOME Bugzilla – Bug 635079
Enter not bound to the save button in the editor
Last modified: 2020-03-17 08:52:07 UTC
Quickly wanted to edit a track. Entered the song title and tried to save by pressing Enter. That did not work.
Created attachment 175901 [details] [review] [TrackEditorDialog] Bind Enter key to save button This calls Respond (ResponseType.Ok) when the Enter key (the KeyPad Enter key) is pressed, which is the same response as the Save button
Created attachment 175902 [details] [review] previous patch didn't return after responding
Review of attachment 175902 [details] [review]: Thanks for the patch ! However there are several problem with it : 1/ If you navigate to the "Cancel" button with the keyboard and hit Enter, this will save your changes instead of cancelling them. 2/ The patch breaks the following feature : if you have several tracks selected, hitting Enter while the focus is in the "Track Title" or "Track Artist" navigates to the next track. For example, this allows you to easily correct metadata for an album. I'm not sure what the best solution is, so I'm open to suggestions.
As for 1/, this could be done by checking ( Focus is Gtk.Button ) and only proceeding if false. When viewing multiple tracks this will also allow for the Forward/Back buttons to be activated the same way. 2/ seems to conflict with the idea behind this bug. Should pressing Enter while "Track Title" or "Track Artist" are focused close the dialog or move to the next track? Opening the editor for multiple tracks implies that the user wants to view/edit information for all of the selected tracks, so I think the most intuitive thing would be to move to the next selected track rather than closing the editor. How to code it this way, I am not so sure. It could be done by simply checking ( TrackCount <= 1), but this would keep the current behaviour, and not bind the enter key when fields other than "Track Title" or "Track Artist" are selected.
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.