After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634953 - Use xulrunner 1.9.2.x in 3.0 moduleset
Use xulrunner 1.9.2.x in 3.0 moduleset
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2010-11-15 23:06 UTC by Luca Ferretti
Modified: 2010-12-03 05:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Changes to use xulrunner 1.9.2 in 3.0 moduleset (3.01 KB, patch)
2010-11-15 23:06 UTC, Luca Ferretti
none Details | Review

Description Luca Ferretti 2010-11-15 23:06:55 UTC
Created attachment 174573 [details] [review]
Changes to use xulrunner 1.9.2 in 3.0 moduleset

The release team agree on using xulrunner 1.9.2 on 3.0 moduleset. It's needed by gjs master in order to build.

Unfortunately it seems that mozilla changed some stuff from 1.9.1.x, so we need to update our module definition

1) the patch for mozilla-js.pc is rejected (not sure it's still needed, I'll check later)

2) --enable-extensions=python/xpcom seems no longer supported

3) using --with-system-sqlite configure complains about missing support to SQLITE_SECURE_DELETE

Here is an inital patch to current moduleset in order to use xulrunner-1.9.2.x. I'm going to ask approval on desktop-devel-list, meanwhile feel free to comment, test and improve this patch.
Comment 1 Luca Ferretti 2010-11-15 23:16:33 UTC
Forgot to mention: I'm going to update only 3.0 moduleset. I think is better keep 1.9.1 in 2.32, but doing so we could need to use gjs from tarball in 2.32 moduleset.
Comment 2 Craig Keogh 2010-11-26 22:53:33 UTC
I'm running your patch in my local tree and mozilla builds fine (actually, not quite, I had to put in a fix caused by bug 565665 and https://bugzilla.mozilla.org/show_bug.cgi?id=614921).

gjs, gnome-js-common build fine too with this mozilla build.
Comment 3 Craig Keogh 2010-11-27 02:43:29 UTC
The patch for mozilla-js.pc is not needed. Header files are installed to /opt/gnome/include/xulrunner-1.9.2.12/ and there is not stable nor unstable directories anymore.

Once you have approval, this is good to go as far as I'm concerned.
Comment 4 Frederic Peters 2010-12-02 15:21:41 UTC
It needs to be updated to apply against the new modulesets; but then go and commit, thanks.