After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634949 - [PATCH] Dialog code doesn't link against libxklavier
[PATCH] Dialog code doesn't link against libxklavier
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: general
CVS HEAD
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-15 22:38 UTC by Robert Ancell
Modified: 2010-11-17 21:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add libxklavier to pkg-config variable for dialog (744 bytes, patch)
2010-11-15 22:38 UTC, Robert Ancell 		needs-work Details | Review
Add libxklavier to pkg-config variable for dialog (1.06 KB, patch)
2010-11-16 22:03 UTC, Robert Ancell 		committed Details | Review

Description Robert Ancell 2010-11-15 22:38:17 UTC 
Created attachment 174570 [details] [review]
Add libxklavier to pkg-config variable for dialog

The dialog code uses libxklavier, but it doesn't link against it.  More paranoid linkers treat this as an error.
Comment 1 Ray Strode [halfline] 2010-11-16 17:30:28 UTC 
Comment on attachment 174570 [details] [review]
Add libxklavier to pkg-config variable for dialog

I think the idea is right, but it's getting added to the wrong PKG_CHECK_MODULES.  the libxklavier support is conditionally available.
Comment 2 Robert Ancell 2010-11-16 22:03:36 UTC 
Created attachment 174636 [details] [review]
Add libxklavier to pkg-config variable for dialog

Updated to use the correct PKG_CHECK_MODULES variable