After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634914 - pulsesrc: add "client" property
pulsesrc: add "client" property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.27
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-15 15:04 UTC by Andy Wingo
Modified: 2011-05-17 07:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to add "client" property (4.33 KB, patch)
2010-11-15 15:05 UTC, Andy Wingo
committed Details | Review

Description Andy Wingo 2010-11-15 15:04:19 UTC
Due to a number of strange reasons involving my company's internal build things, I haven't been able to test this patch. But it does compile!

commit e5afb2009a279ba32c0351428626861de92fc052
Author: Andy Wingo <wingo@oblong.com>
Date:   Mon Nov 15 15:58:28 2010 +0100

    [pulsesink] add "client" property
    
    * ext/pulse/pulsesrc.c (gst_pulsesrc_class_init, gst_pulsesrc_init)
      (gst_pulsesrc_set_property, gst_pulsesrc_get_property)
      (gst_pulsesrc_open): Add a "client" property, as in pulsesink.

 ext/pulse/pulsesrc.c |   34 ++++++++++++++++++++++++++++++----
 ext/pulse/pulsesrc.h |    3 +--
 2 files changed, 31 insertions(+), 6 deletions(-)
Comment 1 Andy Wingo 2010-11-15 15:05:03 UTC
Created attachment 174512 [details] [review]
patch to add "client" property
Comment 2 Wim Taymans 2010-11-16 16:08:50 UTC
looks good, commit after freeze.
Comment 3 Sebastian Dröge (slomo) 2010-12-12 15:13:33 UTC
Comment on attachment 174512 [details] [review]
patch to add "client" property

Agreed, please commit this now with updated Since markers in the docs :)
Comment 4 Sebastian Dröge (slomo) 2011-05-17 07:19:34 UTC
commit 82ee35372bfbe1ba78071502b2f28a25696f6f95
Author: Andy Wingo <wingo@oblong.com>
Date:   Mon Nov 15 15:58:28 2010 +0100

    add "client" property
    
    * ext/pulse/pulsesrc.c (gst_pulsesrc_class_init, gst_pulsesrc_init)
      (gst_pulsesrc_set_property, gst_pulsesrc_get_property)
      (gst_pulsesrc_open): Add a "client" property, as in pulsesink.
    
    Fixes #634914