After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634908 - Several build and testing issues in community extensions
Several build and testing issues in community extensions
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Community Extensions
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-15 14:24 UTC by Rodney Dawes
Modified: 2010-11-15 19:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for bce build/testing issues (7.34 KB, patch)
2010-11-15 14:24 UTC, Rodney Dawes 		needs-work Details | Review
Updated patch to fix issues in review (8.32 KB, patch)
2010-11-15 18:55 UTC, Rodney Dawes 		committed Details | Review

Description Rodney Dawes 2010-11-15 14:24:17 UTC 
Created attachment 174510 [details] [review]
Patch for bce build/testing issues

here are several issues in the banshee-community-extensions build system, which the attached patch fixes:

- Autoconf warning about requirement for AC_PROG_CXX being expanded incorrectly
- Hardcoded nunit-console2 command usage, should be discovered by configure
- Should use --enable-tests for distcheck
- Tests not run by make check when enabled
- Test running rule is overly complicated
- Requires passing --prefix=/usr to configure to test against installed banshee
- Mirage unit tests fail because AddinManager is never initialized
- Redefinition of TARGET variable in a couple Makefile.am files
- Run nunit tests for the OpenVP extension

There's also a failing test in the Mirage extension tests, which I am unsure of the fix for, so I've added the Ignore attribute to it for now:

1) Banshee.Mirage.Tests.SimilarityTests.TestDiscardedDistance : Fails with bad value: 54.438224792480469d
Comment 1 Gabriel Burt 2010-11-15 16:54:23 UTC 
Review of attachment 174510 [details] [review]:

Looks pretty good.  A couple minor issues:

::: build/build.rules.mk
@@ +25,3 @@
+	if test "x$(TEST_ASSEMBLY)" = "xyes"; then \
+		LD_LIBRARY_PATH="/usr/lib/banshee-1:/usr/lib/banshee-1/Extensions:$(EXTENSION_DIR)/..:$(EXTENSION_DIR)${LD_LIBRARY_PATH+:$LD_LIBRARY_PATH}" \
+		MONO_PATH="/usr/lib/banshee-1:/usr/lib/banshee-1/Extensions:$(EXTENSION_DIR)/..:$(EXTENSION_DIR)${MONO_PATH+:$MONO_PATH}" \

This hard-coded /usr/lib/banshee-1 is not OK -- on 64 bit builds it would be /usr/lib64/banshee

::: build/m4/extensions/lastfmfingerprint.m4
@@ +1,3 @@
 AC_DEFUN([BCE_LASTFMFINGERPRINT],
 [
+	AC_REQUIRE([AC_PROG_CXX])dnl

this trailing dnl is superfluous, right?

::: src/Mirage/Banshee.Mirage/Tests/SimilarityTests.cs
@@ +46,3 @@
+        [TestFixtureSetUp]
+        public void SetUp ()
+	    {

Mixture of tabs and spaces for indentation - use spaces
Comment 2 Rodney Dawes 2010-11-15 18:55:38 UTC 
Created attachment 174534 [details] [review]
Updated patch to fix issues in review
Comment 3 Gabriel Burt 2010-11-15 19:00:22 UTC 
Review of attachment 174534 [details] [review]:

Looks good, thanks
Comment 4 Gabriel Burt 2010-11-15 19:14:06 UTC 
Comment on attachment 174534 [details] [review]
Updated patch to fix issues in review

I pushed it to bce