After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634895 - File -> Close and File -> Quit behavior
File -> Close and File -> Quit behavior
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other Linux
: Normal enhancement
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
banshee:ubuntu
Depends on:
Blocks:
 
 
Reported: 2010-11-15 10:04 UTC by Didier Roche
Modified: 2011-01-14 17:13 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Didier Roche 2010-11-15 10:04:55 UTC
As from mpt's spec: https://wiki.ubuntu.com/SoundMenu#Music player section

"A compliant player should also keep playing if you close its window while it is playing; exit if you close its window while it is not playing; and remember exact state across sessions, so that after exit and relaunch it is as if the player had never exited."

So, the idea will be to only have a File -> Close entry menu. Note that clicking on the quit button in the decorator should have the same effect than File -> Close.

Maybe that behavior should be modified only if the soundmenu extension is enabled?

You can find some rationale and more details at https://blueprints.launchpad.net/ubuntu/+spec/packageselection-desktop-n-coherent-behavior-for-apps-in-messagingmenu
Comment 1 Didier Roche 2010-11-15 10:06:49 UTC
banshee:ubuntu
Comment 2 Gabriel Burt 2010-11-15 17:53:02 UTC
The "remember exact state across sessions" part is the non-trivial part of this.  We considered doing that back for Banshee 1.x but rejected it for some reason.  Technically I think it's not too bad; I've been experimenting with it -- making our CoreCache table non-TEMP, saving sources' queries, scroll-offsets, [and TODO] selections.

Is it your intention that this bug include remember-exact-state?
Comment 3 Didier Roche 2010-11-15 18:13:00 UTC
it's part of the same spec, but it can be separated into another bug report if needed. Not mandatory but nice to get for natty if possible.
Comment 4 Conor Curran 2010-12-23 12:30:52 UTC
Will this be fixed in Jan 12th's release, the exact state between session would be a nice to have but the exiting behaviour is quite important for usability I feel.
Comment 5 Bertrand Lorentz 2011-01-10 21:41:10 UTC
I just pushed the code that changes the close/exit behavior to comply with the sound menu spec :
http://git.gnome.org/browse/banshee/commit/?id=bd1e65

I'm keeping this bug open for the "remember exact state across sessions" part.
Comment 6 Gabriel Burt 2011-01-14 17:13:22 UTC
Closing; that's a substantially different issue, can be tracked on a different bug.