GNOME Bugzilla – Bug 634810
Add New Theme - Clean (plus other minor improvements)
Last modified: 2012-01-31 23:24:21 UTC
Created attachment 174425 [details] [review] Patch that does the magic! Hi Everyone. I created a new theme for Quadrapassel/Gnometris, called "Clean". Whilst I like the Tango and Tango Shaded themes, I felt they looked a bit cartoony, so I created this theme by using more saturated/sophisticated colours and also by using a thinner stroke. I also felt that the paused/game over message could use some tweaking, so I made the padding between it and the sides of the clutter area slightly greater, and also made it not bold. Finally I made the fill operation happen after the stroke operation, so that the stroke appeared thinner and less cartoony. You can see these changes in the screenshot attached. Attached is the patch which makes all this happen :) Can someone commit this change to trunk?
Created attachment 174426 [details] Screenshot
This looks *awesome*, to me at least!
Thanks :)
I'm also +1 on this. I'm haven't really worked on the Quadrapassel codebase so I suggest a GNOME games developer that works on this to review/commit it (if no response I'll go ahead and commit).
Looks good to me. Perhaps split the patch into one for the new theme and one for the message tweak.
it would be nice get this committed to master. Rugby471, could you provide us with two "git format-patch"ed patches?
Not really sure how to use git format-patch, could you give me instructions?
Hi, (First make sure that git is set up with your name/email. See http://live.gnome.org/Git/Developers) Do the theme changes, then commit with e.g. git commit -a -m "quadrapassel: Add new theme Clean" Do the message tweak git commit -a -m "quadrapassel: Adjust the message font" git status should say something like: "Your branch is ahead of 'origin/master' by 2 commits" Then to get the patches do: git format-patch origin/master attach the produced patches here :)
Created attachment 176113 [details] [review] Git formatted patch for Clean Theme
Created attachment 176114 [details] [review] Git formatted patch for message font and colour
OK attached are the git-formatted patches Thanks very much for your help Thomas! :)
Comment on attachment 176113 [details] [review] Git formatted patch for Clean Theme committed to master: http://git.gnome.org/browse/gnome-games/commit/?id=cef283d94973c71c3f5cf26f176da4ae7b76198c
Comment on attachment 176114 [details] [review] Git formatted patch for message font and colour http://git.gnome.org/browse/gnome-games/commit/?id=4d9e600024f609fae01ea184aee972e325b30fc5
Awesome work Andrew! I amended the patces to include a reference to this bug. I should have mentioned that in my format-patch instructions. Thanks for the patches :)
Thanks Thomas :)
This bug is being reassigned to the "quadrapassel" component so we can close the gnometris bugzilla component. Apologies for the mass email!