After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634779 - MetaWindowGroup: further optimize paints by using current scissor
MetaWindowGroup: further optimize paints by using current scissor
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Dan Winship
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2010-11-13 20:59 UTC by Owen Taylor
Modified: 2010-11-18 18:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MetaWindowGroup: further optimize paints by using current scissor (2.50 KB, patch)
2010-11-13 20:59 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2010-11-13 20:59:19 UTC 
When in a partial stage paint, we can combine that with the visibility
information in MetaWindowGroup to further eliminate unneeded drawing.

Since there is no current Clutter API to access the current clip,
drop to using GL directly.
Comment 1 Owen Taylor 2010-11-13 20:59:22 UTC 
Created attachment 174406 [details] [review]
MetaWindowGroup: further optimize paints by using current scissor
Comment 2 Dan Winship 2010-11-18 18:06:30 UTC 
Comment on attachment 174406 [details] [review]
MetaWindowGroup: further optimize paints by using current scissor

I don't really know GL at all but it all looks right based on some quick skimming of docs.

Can you explain in the comment that the GL scissor box is the COGL clip region?
Comment 3 Owen Taylor 2010-11-18 18:59:36 UTC 
Pushed with comment improved to:

  /* When doing a partial stage paint, Clutter will set the GL scissor
   * box to the clip rectangle for the partial repaint. We combine the screen
   * rectangle with the scissor box to get the region we need to
   * paint. (Strangely, the scissor box sometimes seems to be bigger
   * than the stage ... Clutter should probably be clampimg)
   */

Which is hopefully more explanator.

Attachment 174406 [details] pushed as 5963990 - MetaWindowGroup: further optimize paints by using current scissor