After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634753 - g_iconv takes gsize, not uint
g_iconv takes gsize, not uint
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings: GLib
0.10.x
Other Linux
: Normal major
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-13 14:07 UTC by Jaroslav Šmíd
Modified: 2018-05-20 17:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sample patch (572 bytes, patch)
2010-11-19 19:52 UTC, Luca Bruno 		none Details | Review
glib-2.0: Fix IConv.iconv() (951 bytes, patch)
2018-05-20 17:11 UTC, Rico Tzschichholz 		committed Details | Review

Description Jaroslav Šmíd 2010-11-13 14:07:21 UTC 
g_iconv function takes gsize for inbytes_left and outbytes_left. In vala bindings, uint is used, which is wrong.
Comment 1 Luca Bruno 2010-11-19 19:52:29 UTC 
Created attachment 174883 [details] [review]
sample patch

Patch should be something like this (except uint8 instead of char maybe) but then there's a vala bug:
(gsize) (&data_length1)
The length of the array is erroneously casted to gsize rather than gsize*.
Comment 2 Rico Tzschichholz 2018-05-20 17:11:02 UTC 
Created attachment 372249 [details] [review]
glib-2.0: Fix IConv.iconv()
Comment 3 Rico Tzschichholz 2018-05-20 17:56:55 UTC 
Attachment 372249 [details] pushed as 90b7a26 - glib-2.0: Fix IConv.iconv()