After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634708 - RadioButton get_group() etc use AV* return
RadioButton get_group() etc use AV* return
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Gtk2
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on: 634706
Blocks:
 
 
Reported: 2010-11-12 19:28 UTC by Kevin Ryde
Modified: 2010-11-21 20:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch and test cases (11.35 KB, patch)
2010-11-12 19:28 UTC, Kevin Ryde 		committed Details | Review

Description Kevin Ryde 2010-11-12 19:28:50 UTC 
Created attachment 174352 [details] [review]
patch and test cases

This is an idea to have gtk_radio_button_get_group() and friends use an AV* return to let the typemap do some work, instead of explicit PUSHs.
Comment 1 Torsten Schoenfeld 2010-11-13 00:11:46 UTC 
Patch looks good to me in general, but I gotta ask: what's your motivation?  what do we gain?
Comment 2 Kevin Ryde 2010-11-13 21:34:01 UTC 
I had this bouncing around for a while.  I saw the pod saying "list" (eg. Gtk2::RadioMenuItem) which is a bit unclear, being an arrayref not multiple values as such, and wondered that an "arrayref" type from the typemap could indicate it in the code and the pod.

There's almost an opportunity for some code sharing between the four places, some return type like "GSList_of_GObject", unless the widget ones should have the silly "ref sink" and the RadioAction one not, and except that most other GSList returns are done as lists style return instead of arrayref.
Comment 3 Torsten Schoenfeld 2010-11-21 20:51:18 UTC 
Alright, convinced.  Committed.  Thanks.