Bug 634573 – Crash when importing ics file

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 634573 - Crash when importing ics file


Summary:	Crash when importing ics file


Status:	RESOLVED FIXED

Product:	evolution-data-server
Classification:	Platform
Component:	Calendar
Version:	2.32.x (obsolete)
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	evolution-calendar-maintainers
QA Contact:	Evolution QA team

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2010-11-11 09:53 UTC by Milan Crha
Modified:	2010-11-19 14:49 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
test event (238.84 KB, text/plain) 2010-11-11 09:53 UTC, Milan Crha		Details
eds patch (8.24 KB, patch) 2010-11-19 14:41 UTC, Milan Crha	committed	Details \| Review
eex patch (3.57 KB, patch) 2010-11-19 14:42 UTC, Milan Crha	committed	Details \| Review

Description Milan Crha 2010-11-11 09:53:57 UTC

Created attachment 174234 [details]
test event

Moving from a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=652132

e-calendar-factory can crash when importing

http://www.hds.com/anz/events/hitachi-data-systems-melbourne-christmas-party-2010.ics

(I attached it). Downstream reported tried with the evolution-exchange calendar, I tried with the Personal calendar. Both are crashing, mine on a different place.

+ Trace 224629

Thread 1 (Thread 1872)

#0 receive_attachments
at e-cal-backend-exchange.c line 1932
#1 receive_objects
at e-cal-backend-exchange-calendar.c line 1728
#2 e_cal_backend_sync_receive_objects
at e-cal-backend-sync.c line 302
#3 _e_cal_backend_receive_objects
at e-cal-backend-sync.c line 704
#4 e_cal_backend_receive_objects
at e-cal-backend.c line 1090
#5 impl_Cal_receiveObjects
at e-data-cal.c line 431
#6 _e_gdbus_gdbus_cclosure_marshaller_BOOLEAN__OBJECT_STRING
at e-gdbus-marshallers.c line 377
#7 g_closure_invoke
at gclosure.c line 766
#8 signal_emit_unlocked_R
at gsignal.c line 3252
#0 fetch_attachments
at e-cal-backend-file.c line 2896
#1 e_cal_backend_file_receive_objects
at e-cal-backend-file.c line 3072
#2 e_cal_backend_sync_receive_objects
at e-cal-backend-sync.c line 302
#3 _e_cal_backend_receive_objects
at e-cal-backend-sync.c line 704
#4 e_cal_backend_receive_objects
at e-cal-backend.c line 1090
#5 impl_Cal_receiveObjects

---Type <return> to continue, or q <return> to quit---q
0xe21610 "BEGIN:VCALENDAR\r\nPRODID:-//Microsoft Corporation//Outlook 12.0 MIMEDIR//EN\r\nVERSQuit
(gdb) l
2891			GMappedFile *mapped_file;
2892			GError *error = NULL;
2893	
2894			mapped_file = g_mapped_file_new (sfname, FALSE, &error);
2895			if (!mapped_file) {
2896				g_message ("DEBUG: could not map %s: %s\n",
2897					   sfname, error->message);
2898				g_error_free (error);
2899				continue;
2900			}
(gdb) p sfname
$1 = (gchar *) 0x0
(gdb) p error
$2 = (GError *) 0x0

Comment 1 Milan Crha 2010-11-19 14:41:06 UTC

Created attachment 174843 [details] [review]
eds patch

for evolution-data-server;

There was no support for inline attachments in ECalComponent, which later could lead to anything, in this case to a crash. I added support for inline attachments into ECalComponent, and fixed couple things here and there when testing things around this.

Comment 2 Milan Crha 2010-11-19 14:42:11 UTC

Created attachment 174844 [details] [review]
eex patch

for evolution-exchange;

Related part to this. May address could things as well.

Comment 3 Milan Crha 2010-11-19 14:49:53 UTC

Created commit 92bf50a in eds master (2.91.3+)
Created commit 8e936b3 in eds gnome-2-32 (2.32.2+)

Created commit 01d0da5 in eex master (2.91.3+)
Created commit 9ad860d in eex gnome-2-32 (2.32.2+)