After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634426 - Disallow tags named HEAD
Disallow tags named HEAD
Status: RESOLVED FIXED
Product: sysadmin
Classification: Infrastructure
Component: Git
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Sysadmins
GNOME Sysadmins
: 664279 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-11-09 16:12 UTC by Jeff Schroeder
Modified: 2012-03-05 19:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Allows deleting HEAD tags. (1.65 KB, patch)
2011-10-31 12:21 UTC, Krzesimir Nowak 		committed Details | Review

Description Jeff Schroeder 2010-11-09 16:12:02 UTC 
This is a tracking bug until myself or someone else gets around to it.

http://git.gnome.org/browse/gitadmin-bin/tree/pre-receive-check-policy This needs to be updated.
Comment 1 Krzesimir Nowak 2011-10-31 12:21:31 UTC 
Created attachment 200329 [details] [review]
Allows deleting HEAD tags.

Rejecting creation of tag named HEAD is implemented as I see in line 176 [1]. But it would be useful to allow deleting tags named HEAD. There are probably some projects that have such tag (e.g. file-roller). The attached patch changes a logic a bit to achieve this. It would be good to test it on some dummy git repository. I tested it by direct calling:

./pre-receive-check-policy 321 000 refs/tags/HEAD (printed nothing and returned 0)

and

./pre-receive-check-policy 321 000 refs/tags/foo (printed a warning and returned 1)

[1] http://git.gnome.org/browse/gitadmin-bin/tree/pre-receive-check-policy#n176
Comment 2 Owen Taylor 2011-10-31 15:10:45 UTC 
Don't really remember the background here about what blows up if there is a tag named HEAD. Complete list of modules with tags named HEAD:

file-roller.git
garnome.git
gnome-alsamixer.git
libsounds.git
ORBit2.git
archive/elysium-download.git
archive/etherterm.git
archive/gnome-devel.git
archive/libelysium.git
archive/ORBit.git

patch looks fine though, I'll push it.
Comment 3 Owen Taylor 2011-10-31 15:12:53 UTC 
Closing since it looks like Jeff just forgot to close it earlier when he pushed a fix to gitadmin-bin
Comment 4 Owen Taylor 2012-03-05 19:41:58 UTC 
*** Bug 664279 has been marked as a duplicate of this bug. ***