After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634348 - Fix various warnings on gtk+-3 branch
Fix various warnings on gtk+-3 branch
Status: RESOLVED WONTFIX
Product: murrine
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: murrine-maint
murrine-maint
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2010-11-08 18:53 UTC by Vincent Untz
Modified: 2018-07-11 12:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove unneeded argument to g_scanner_warn() (2.30 KB, patch)
2010-11-08 18:53 UTC, Vincent Untz 		none Details | Review
Remove unused variables (2.89 KB, patch)
2010-11-08 19:02 UTC, Vincent Untz 		none Details | Review
Add function declarations to support.h to fix warnings (1.07 KB, patch)
2010-11-08 19:02 UTC, Vincent Untz 		none Details | Review
Initialize some variables to remove warnings (2.06 KB, patch)
2010-11-08 19:02 UTC, Vincent Untz 		none Details | Review
Remove unused static functions (1.79 KB, patch)
2010-11-08 19:02 UTC, Vincent Untz 		none Details | Review
Use MRN_SHADOW_* instead of GTK_SHADOW_* (3.68 KB, patch)
2010-11-08 19:02 UTC, Vincent Untz 		none Details | Review
Help compiler find out that a variable is always set (735 bytes, patch)
2010-11-08 19:02 UTC, Vincent Untz 		none Details | Review

Description Vincent Untz 2010-11-08 18:53:52 UTC 
The following patches all fix various warnings on the gtk+-3 branch.
Comment 1 Vincent Untz 2010-11-08 18:53:53 UTC 
Created attachment 174080 [details] [review]
Remove unneeded argument to g_scanner_warn()

This causes a warning.
Comment 2 Vincent Untz 2010-11-08 19:02:07 UTC 
Created attachment 174081 [details] [review]
Remove unused variables
Comment 3 Vincent Untz 2010-11-08 19:02:08 UTC 
Created attachment 174082 [details] [review]
Add function declarations to support.h to fix warnings
Comment 4 Vincent Untz 2010-11-08 19:02:10 UTC 
Created attachment 174083 [details] [review]
Initialize some variables to remove warnings
Comment 5 Vincent Untz 2010-11-08 19:02:13 UTC 
Created attachment 174084 [details] [review]
Remove unused static functions
Comment 6 Vincent Untz 2010-11-08 19:02:15 UTC 
Created attachment 174085 [details] [review]
Use MRN_SHADOW_* instead of GTK_SHADOW_*

This is needed to avoid warnings when comparing of MurrineShadowType.
Comment 7 Vincent Untz 2010-11-08 19:02:17 UTC 
Created attachment 174086 [details] [review]
Help compiler find out that a variable is always set
Comment 8 Andrea Cimitan 2010-11-08 20:02:39 UTC 
You're my hero! Will apply them tomorrow!
Comment 9 André Klapper 2018-07-11 12:36:19 UTC 
Murrine is not under active development anymore and had its last code changes
in 2012. Its codebase has been archived:
https://gitlab.gnome.org/Archive/murrine/commits/master

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the
responsibility for active development again.